From owner-freebsd-current@freebsd.org Fri Feb 14 12:06:52 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9907D231CE5 for ; Fri, 14 Feb 2020 12:06:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48JsYm1Vdsz4Tbm for ; Fri, 14 Feb 2020 12:06:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 31A8F231CE4; Fri, 14 Feb 2020 12:06:52 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 31728231CE3 for ; Fri, 14 Feb 2020 12:06:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48JsYm0WBpz4Tbl; Fri, 14 Feb 2020 12:06:51 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x343.google.com with SMTP id g1so9697103wmh.4; Fri, 14 Feb 2020 04:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=hK4tklaI5wF3Dlx1mJ7tLwoFz3N09NuHCyrDXPrg8Yg=; b=ot3U1BqY6WjQ3BTqEVT/DQfSJ6cAhq89ZZxzbTkytuaBEfOtognbKxpG+mKK9sRqSl Fh3SSuUD/MVI/UZy4tn+dBSyzoiBXio13TjWQXwMJSr2XJxBqiWvT5Gk5dOImKL0Kk94 7jgXDGZDM9c0nEf1ddZ1i9WajQ8FUTdVeYyDlHu8AUs2iDR4rAsZX3y6Y4qmZVaA9RMq 2uoLfo+BWA7wnTf5tlwEnMAttEZM4VV27nXBLt16EitDz57JxOLvyVmy6BNPGHO4xXEF 1ilXu0aLoLbjsc7l231t8fTXmCkTwMhb69dd9IAdk1v4Cu7ktq5L7j+Q8mM2ipBq05kC zHmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=hK4tklaI5wF3Dlx1mJ7tLwoFz3N09NuHCyrDXPrg8Yg=; b=BtJMxdLkNjRT0MLS1M5sWFgtjDROQOebGLxRGhLAjROJi+KFPHO8LcMxryhP73FA9r puYnwY5TT/PCZnJe0Zk5UCdwtFfx8B2D2JIlpAaKEV56DqwDcSaqHmkbdd0GCwpazlLM 7SI70d4O+rNwc0wRpJpIoTiz+T3BBsUlAyQ/TgXyNDxEdnuA4jJ9TOqC8soNNTqUDiML SKx6jh1OpNp9AOTEbkG9/GbaWb0/ZL976LIq6S2+kPPqLN4+RKGrD9D9UY4IVe/3iVIS xZG/feC9S49fUUV9xV3vM2/7s+zBYMLRlXs283dtKFpA2jv6z5qvzCSjuSJsLa21KHj/ SoaA== X-Gm-Message-State: APjAAAXm7nog3ft16IzkLWBmiqZcmiXoeWOx52vmI3GQ3nDMvjB9NeBV fu3ehdP+yU3pu3x5Vexpls3oPrOMG+egOhrXWtQwzw== X-Google-Smtp-Source: APXvYqw4QM6YF9xdYd5i4sqt4ZHTjfrv4hu4yN7E/f3+yqO/K0HT44JPaEJCzAcqvFykOCyqk3UgZjnMggoxHHqBIh8= X-Received: by 2002:a1c:e483:: with SMTP id b125mr4415013wmh.187.1581682010522; Fri, 14 Feb 2020 04:06:50 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5d:6b02:0:0:0:0:0 with HTTP; Fri, 14 Feb 2020 04:06:49 -0800 (PST) In-Reply-To: <20200214115920.GL1238@albert.catwhisker.org> References: <20200214115920.GL1238@albert.catwhisker.org> From: Mateusz Guzik Date: Fri, 14 Feb 2020 13:06:49 +0100 Message-ID: Subject: Re: r357907 seems to have broken sys/kern/vfs_default.c To: current@freebsd.org, mjg@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48JsYm0WBpz4Tbl X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Feb 2020 12:06:52 -0000 I already fixed that in r357909, sorry. On 2/14/20, David Wolfskill wrote: > ... > Building > /common/S4/obj/usr/src/amd64.amd64/sys/GENERIC/modules/usr/src/sys/modules/zfs/vdev_file.o > --- vfs_default.o --- > /usr/src/sys/kern/vfs_default.c:576:10: error: implicit declaration of > function 'lockmgr_lock_fast_path' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > return (lockmgr_lock_fast_path(&vp->v_lock, flags, > ^ > Building /common/S4/obj/usr/src/amd64.amd64/sys/GENERIC/vfs_hash.o > /usr/src/sys/kern/vfs_default.c:576:10: note: did you mean > 'lockmgr_lock_flags'? > /usr/src/sys/sys/lockmgr.h:73:6: note: 'lockmgr_lock_flags' declared here > int lockmgr_lock_flags(struct lock *lk, u_int flags, > ^ > 1 error generated. > *** [vfs_default.o] Error code 1 > > make[2]: stopped in /common/S4/obj/usr/src/amd64.amd64/sys/GENERIC > .ERROR_TARGET='vfs_default.o' > .ERROR_META_FILE='/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC/vfs_default.o.meta' > .... > > > Running: > FreeBSD freebeast.catwhisker.org 13.0-CURRENT FreeBSD 13.0-CURRENT #820 > r357854M/357854: Thu Feb 13 04:52:51 PST 2020 > root@freebeast.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC > amd64 > > and updating with sources at r357908. > > Peace, > david > -- > David H. Wolfskill david@catwhisker.org > What if McConnell had voted to convict Trump in the impeachment "trial?" > > See http://www.catwhisker.org/~david/publickey.gpg for my public key. > -- Mateusz Guzik