From nobody Fri Nov 21 15:03:02 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dCdkZ4fQqz6HK72 for ; Fri, 21 Nov 2025 15:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dCdkZ1kmnz3lxC for ; Fri, 21 Nov 2025 15:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763737382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZqdOmhRvYZWI+vDo4YHtgaP67+1zKSqpoK7ha04/vTI=; b=Y8AxkcE5VJi6/Ghkn4hBvqZNnC9hvQUYToy3yzNE5x23hqs+Q/OB3bCUGjkrpmkl9BhUi2 1q5/ciXW9spPqe0HL9oinGZTgmCUKEU5EKiHcxSsA/yYkAgCAEAxVwYIlUhZK6MKsiHOos hX5Q6eyPEOTTM5eweDEk7qDxPxhcWmzvw4vNHC8M54fKwov9yi2x72RXI7iepy4m7ypWGS TkVnzA5zw+nXJbnRznhkGAMB+zyKtQ44YUJikZQ1x9kLU6r23W/zgOj1neKeel2bfBRK5Q /Mi64mZMhMXp1m3T5nfpJCj0jGk/o+K9eHqwVAvJGqG0u03sRWylLYtSFa4B5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763737382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZqdOmhRvYZWI+vDo4YHtgaP67+1zKSqpoK7ha04/vTI=; b=u3fosXpAdQRCduBMTXu/TaB22h18QTmLtEiQt/eFbRkPRDz5hmly1K8iWk/1eJNSh1MGV9 F2CaaKI15oXeMH1L1gujioWLFDRaZRvHkAkbqEpcXdOikE2zdDYB/N8M40ueZy69/sTqtu YsvhdUmJ+E+HXETII9LZbHYwZjfoPSrXVpKyYxo85gFWthjNRRPMHsX5qlyeJgz4RGRfpj nZUEy2smnu4i+FUEk+beUOMg9rYtfzoR65e1nCgqbezBSu3kI0IxBXl8xdOP5JK6Rv75o6 fJFKKIoT3bMK7xPsgDED2XhrQPPPr5B1GXzORuxZ4Z1SCZO6ot/e/XVTvwCX0g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763737382; a=rsa-sha256; cv=none; b=V9u01y6GhK0FbZ1poO10a8x38ykQdQstZOXaVLZeCol5/mt5gb4pyz2gLfyEm87AD8hffX mIMVp9LAg5huH3HvAmJvJLD9t1uXQsawK8tDUAeHQn9u5+OWtuoYG0xX1hAaraVV4hLJ6N JN1GBEb0HwlPU+Go3o0LeJ6vQydDkjrfo0FchMU534dmBxHZB0EdIZee3ADNsK6a4gJjuN kdAw+d1hIIiwKGXTct0zdBdeDKU9pdO4x3q9jKMO1hZKe2mJCze5atamxhHaNq8QlHVU3B NR9vqnCgMh5ZE2Em4yy7VfaRJJn/LCXxSApPKijo4PC7dv4LghD4Nr+WpQEkPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dCdkZ1K4Mz2Yg for ; Fri, 21 Nov 2025 15:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2e57f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 21 Nov 2025 15:03:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: d8bfcacd12ab - main - vm_fault: add a verifier that the PG_ZERO page is indeed zeroed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d8bfcacd12aba73188c44a157c707908e275825d Auto-Submitted: auto-generated Date: Fri, 21 Nov 2025 15:03:02 +0000 Message-Id: <69207f26.2e57f.6fa41ca0@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=d8bfcacd12aba73188c44a157c707908e275825d commit d8bfcacd12aba73188c44a157c707908e275825d Author: Konstantin Belousov AuthorDate: 2025-11-21 08:34:51 +0000 Commit: Konstantin Belousov CommitDate: 2025-11-21 15:02:21 +0000 vm_fault: add a verifier that the PG_ZERO page is indeed zeroed Compiled under INVARIANTS, activated by the same sysctl debug.vm_check_pg_zero. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D53850 --- sys/vm/vm_fault.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/sys/vm/vm_fault.c b/sys/vm/vm_fault.c index 2e150b368d71..3bf16778d987 100644 --- a/sys/vm/vm_fault.c +++ b/sys/vm/vm_fault.c @@ -85,6 +85,8 @@ #include #include #include +#include +#include #include #include #include @@ -1220,6 +1222,24 @@ vm_fault_zerofill(struct faultstate *fs) if ((fs->m->flags & PG_ZERO) == 0) { pmap_zero_page(fs->m); } else { +#ifdef INVARIANTS + if (vm_check_pg_zero) { + struct sf_buf *sf; + unsigned long *p; + int i; + + sched_pin(); + sf = sf_buf_alloc(fs->m, SFB_CPUPRIVATE); + p = (unsigned long *)sf_buf_kva(sf); + for (i = 0; i < PAGE_SIZE / sizeof(*p); i++, p++) { + KASSERT(*p == 0, + ("zerocheck failed page %p PG_ZERO %d %jx", + fs->m, i, (uintmax_t)*p)); + } + sf_buf_free(sf); + sched_unpin(); + } +#endif VM_CNT_INC(v_ozfod); } VM_CNT_INC(v_zfod);