From owner-cvs-all  Sun Jan 14  1:51: 2 2001
Delivered-To: cvs-all@freebsd.org
Received: from dt051n37.san.rr.com (dt051n37.san.rr.com [204.210.32.55])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6A21F37B400; Sun, 14 Jan 2001 01:50:38 -0800 (PST)
Received: from FreeBSD.org (Studded@master [10.0.0.2])
	by dt051n37.san.rr.com (8.9.3/8.9.3) with ESMTP id BAA58441;
	Sun, 14 Jan 2001 01:50:37 -0800 (PST)
	(envelope-from DougB@FreeBSD.org)
Message-ID: <3A61766D.80E7349C@FreeBSD.org>
Date: Sun, 14 Jan 2001 01:50:37 -0800
From: Doug Barton <DougB@FreeBSD.org>
Organization: Triborough Bridge & Tunnel Authority
X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.12 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Greg Lehey <grog@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/vinum vinumlock.c vinumvar.h
References: <200101140634.f0E6Ywc16968@freefall.freebsd.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

	Seems to be a world breaker:

cc -O -pipe -I/usr/src/sbin/vinum/../../sys -Wall -DVINUMDEBUG   -c
/usr/src/sbin/vinum/list.c
/usr/src/sbin/vinum/list.c: In function `vinum_info':
/usr/src/sbin/vinum/list.c:1005: structure has no member named `plexno'
/usr/src/sbin/vinum/list.c:1013: structure has no member named `plexno'
/usr/src/sbin/vinum/list.c:1021: structure has no member named `plexno'
*** Error code 1

Stop in /usr/src/sbin/vinum.


Greg Lehey wrote:
> 
> grog        2001/01/13 22:34:58 PST
> 
>   Modified files:
>     sys/dev/vinum        vinumlock.c vinumvar.h
>   Log:
>   struct rangelock: Remove the field 'plex' from the entry.  Range locks
>   are accessed only via the plex, so there's never any confusion as to
>   the plex number.  This value was, as a result, unused.
> 
>   Revision  Changes    Path
>   1.21      +2 -5      src/sys/dev/vinum/vinumlock.c
>   1.36      +1 -2      src/sys/dev/vinum/vinumvar.h
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/vinum/vinumlock.c.diff?&r1=1.20&r2=1.21&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/vinum/vinumvar.h.diff?&r1=1.35&r2=1.36&f=h

-- 
    "The most difficult thing in the world is to know how to do a thing and
     to watch someone else do it wrong without comment."
                     -- Theodore H. White

	Do YOU Yahoo!?


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message