From owner-svn-src-user@freebsd.org Fri Mar 30 01:31:07 2018 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F191BF63216 for ; Fri, 30 Mar 2018 01:31:06 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9FD596EFE5; Fri, 30 Mar 2018 01:31:06 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9959F21FC1; Fri, 30 Mar 2018 01:31:06 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w2U1V6cv060978; Fri, 30 Mar 2018 01:31:06 GMT (envelope-from jeff@FreeBSD.org) Received: (from jeff@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w2U1V6cS060977; Fri, 30 Mar 2018 01:31:06 GMT (envelope-from jeff@FreeBSD.org) Message-Id: <201803300131.w2U1V6cS060977@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jeff set sender to jeff@FreeBSD.org using -f From: Jeff Roberson Date: Fri, 30 Mar 2018 01:31:06 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r331753 - user/jeff/numa/sys/vm X-SVN-Group: user X-SVN-Commit-Author: jeff X-SVN-Commit-Paths: user/jeff/numa/sys/vm X-SVN-Commit-Revision: 331753 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 01:31:07 -0000 Author: jeff Date: Fri Mar 30 01:31:06 2018 New Revision: 331753 URL: https://svnweb.freebsd.org/changeset/base/331753 Log: Fix a couple of pageout control issues. Reset pass after we meet our target. Don't sleep if we met the target. Don't touch unnecessary pages in vm_pageout_free_pages(). Cache misses to page structures are the biggest cost of the pageout daemon. Modified: user/jeff/numa/sys/vm/vm_pageout.c Modified: user/jeff/numa/sys/vm/vm_pageout.c ============================================================================== --- user/jeff/numa/sys/vm/vm_pageout.c Fri Mar 30 01:22:47 2018 (r331752) +++ user/jeff/numa/sys/vm/vm_pageout.c Fri Mar 30 01:31:06 2018 (r331753) @@ -1108,9 +1108,12 @@ vm_pageout_free_pages(vm_object_t object, vm_page_t m, p = vm_page_next(m); vm_page_free(m); /* Iterate through the block range and free compatible pages. */ - /* XXX Fix cache miss on last page. */ - for (m = p; m != NULL && m->pindex < start + pcount; m = p) { - p = TAILQ_NEXT(m, listq); + for (m = p; m != NULL; m = p) { + /* Don't cache miss for the next page after the tail. */ + if (m->pindex < start + pcount) + p = TAILQ_NEXT(m, listq); + else + p = NULL; vm_page_change_lock(m, mtxp); if (vm_page_held(m) || vm_page_busied(m) || m->queue != PQ_INACTIVE) @@ -1869,7 +1872,7 @@ vm_pageout_worker(void *arg) * scan, then sleep a bit and try again. */ vm_domain_pageout_unlock(vmd); - if (pass > 1) + if (pass > 1 && !target_met) pause("pwait", hz / VM_INACT_SCAN_RATE); } else { /* @@ -1899,6 +1902,8 @@ vm_pageout_worker(void *arg) */ if (!target_met) pass++; + else if (shortage) + pass = 1; } }