From owner-svn-src-head@FreeBSD.ORG  Tue Jul 16 15:02:34 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 591D09E8;
 Tue, 16 Jul 2013 15:02:34 +0000 (UTC)
 (envelope-from pluknet@gmail.com)
Received: from mail-wg0-x234.google.com (mail-wg0-x234.google.com
 [IPv6:2a00:1450:400c:c00::234])
 by mx1.freebsd.org (Postfix) with ESMTP id 48955C2C;
 Tue, 16 Jul 2013 15:02:33 +0000 (UTC)
Received: by mail-wg0-f52.google.com with SMTP id b12so717900wgh.31
 for <multiple recipients>; Tue, 16 Jul 2013 08:02:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=ktGbGyhT+Z9Vb4TQxF+HkNbP/DFhIYbTcuiMoNpTz4I=;
 b=Hf3E9FXlNhr1XJMv8mLvljxccNAgTMa6AlcicpPbUMy9FrhdyRry6j99xj/ssIrUrW
 j/jIr3YsBdX2jxYvixvxg6pni5+qp/CrjMmbF15pmeqPJQoBvHWkkiVywSlIXUHzTPDL
 AyfioDAGAnP5KONPgI3Qi0g8MjqFv6kQkaCKHNFPDQI9GU6WVwY00WkyA656xNjLkTNc
 ZyA4WNloWOM4199q1gOWq8TczmywZeM1F5RQyX/YLkJjTr4liUaQTIpVLkjutN/Bo0JB
 TS3z0XUq69VBRBVP90kuq0UIpctC96W+MaAmlef6TC8Zr4FfU51A8j/zDPTgJt+zg0ZR
 DFvQ==
MIME-Version: 1.0
X-Received: by 10.180.13.5 with SMTP id d5mr1413802wic.56.1373986952483; Tue,
 16 Jul 2013 08:02:32 -0700 (PDT)
Sender: pluknet@gmail.com
Received: by 10.216.82.70 with HTTP; Tue, 16 Jul 2013 08:02:32 -0700 (PDT)
In-Reply-To: <201307161002.15094.jhb@freebsd.org>
References: <201307151540.r6FFewZc049719@svn.freebsd.org>
 <201307161002.15094.jhb@freebsd.org>
Date: Tue, 16 Jul 2013 19:02:32 +0400
X-Google-Sender-Auth: KK9zu0NotcEZtmBrTxTFPx90L04
Message-ID: <CAE-mSOKdpoMF7qWJ=fpD6WfsK0vs4yJa78zR_ySBLr7QkhPhQw@mail.gmail.com>
Subject: Re: svn commit: r253367 - in head/sys: i386/i386 mips/mips
 powerpc/powerpc sparc64/sparc64
From: Sergey Kandaurov <pluknet@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" <ae@freebsd.org>,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jul 2013 15:02:34 -0000

On 16 July 2013 18:02, John Baldwin <jhb@freebsd.org> wrote:
> On Monday, July 15, 2013 11:40:58 am Andrey V. Elsukov wrote:
>> Author: ae
>> Date: Mon Jul 15 15:40:57 2013
>> New Revision: 253367
>> URL: http://svnweb.freebsd.org/changeset/base/253367
>>
>> Log:
>>   Include sys/systm.h after sys/param.h.
>>
>>   Suggested by:       pluknet
>
> Does this fix something?
>
> The normal style rule IIUC is to put <sys/types.h> or <sys/param.h> first,
> and then to sort alphabetically.

In addition to the style bug mentioned by Bruce, this also fixes build error
on i386. See r252434, r253351 for details.

In file included from /src/sys/i386/i386/uio_machdep.c:48:
/src/sys/sys/systm.h:190:6: error: conflicting types for 'critical_exit'
void    critical_exit(void);
        ^
./machine/counter.h:172:3: note: previous implicit declaration is here
                critical_exit();
                ^
JFYI.

-- 
wbr,
pluknet