Date: Thu, 2 Jul 2020 00:11:11 +0800 From: Li-Wen Hsu <lwhsu@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Jason Bacon <bacon4000@gmail.com>, ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540967 - in head/net/lualdap: . files Message-ID: <CAKBkRUxNZkKx9dNA=yWBtQO-7bY6Nie73rnasR20yJEhnzPDxA@mail.gmail.com> In-Reply-To: <20200701155947.GA50158@FreeBSD.org> References: <202007011406.061E6Cxt041119@repo.freebsd.org> <20200701151607.GA6554@FreeBSD.org> <a5b62c40-e342-829c-24fc-9f8b4a37874d@gmail.com> <20200701155947.GA50158@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 1, 2020 at 11:59 PM Alexey Dokuchaev <danfe@freebsd.org> wrote: > > On Wed, Jul 01, 2020 at 10:28:15AM -0500, Jason Bacon wrote: > > On 2020-07-01 10:16, Alexey Dokuchaev wrote: > > > On Wed, Jul 01, 2020 at 02:06:12PM +0000, Li-Wen Hsu wrote: > > >> New Revision: 540967 > > >> URL: https://svnweb.freebsd.org/changeset/ports/540967 > > >> > > >> Log: > > >> Update to 1.2.5 > > >> > > >> ... > > >> -MAKE_ARGS+= LUA_LIBDIR="${LUA_LIBDIR}" \ > > >> - LUA_INC="${LUA_INCDIR}" \ > > >> - OPENLDAP_LIB="-L${LOCALBASE}/lib -lldap" \ > > >> - LUA_VERSION_NUM="${LUA_VER_STR}0" \ > > >> - CC="${CC}" > > >> +MAKE_ARGS+= CPPFLAGS="-I${LOCALBASE}/include -I${LUA_INCDIR}" \ > > >> + LDFLAGS="-L${LOCALBASE}/lib" \ > > >> + CC=${CC} > > > Dropping quotes around ${CC} can potentially break things and also > > > had contributed some unnecessary repo churn. :( > > > > I would have thought ${CC} is always just the compiler name sans > > flags/whitespace, but danfe is correct. There's one case in Mk that > > would call for quotes: > > Another thing which rings the bell is ccache which can be invoked as > "ccache compiler [compiler options]", thus CC="ccache compiler". Nice catch! Thanks and fixed in r540974. Li-Wen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUxNZkKx9dNA=yWBtQO-7bY6Nie73rnasR20yJEhnzPDxA>