From owner-freebsd-x11@FreeBSD.ORG Mon Feb 3 09:20:53 2014 Return-Path: Delivered-To: x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 15632F4E for ; Mon, 3 Feb 2014 09:20:53 +0000 (UTC) Received: from mailrelay008.isp.belgacom.be (mailrelay008.isp.belgacom.be [195.238.6.174]) by mx1.freebsd.org (Postfix) with ESMTP id A8B6A1032 for ; Mon, 3 Feb 2014 09:20:52 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnMGAFte71JR8ZJI/2dsb2JhbABZgww4vm+BAhd0giUBAQU6HCMQCw4KCSUPKh4GE4gJAc0HF45WMweEOAEDmCmSIoMuOw Received: from 72.146-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.146.72]) by relay.skynet.be with ESMTP; 03 Feb 2014 10:20:45 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id s139KhqJ003798; Mon, 3 Feb 2014 10:20:43 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Mon, 3 Feb 2014 10:20:43 +0100 From: Tijl Coosemans To: Koop Mast Subject: Re: pixman malformed conditional '$' Message-ID: <20140203102043.5d3ebb5c@kalimero.tijl.coosemans.org> In-Reply-To: <52EF51C8.4090200@rainbow-runner.nl> References: <20140203031952.GA46364@DataIX.net> <52EF51C8.4090200@rainbow-runner.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jhellenthal@dataix.net, x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Feb 2014 09:20:53 -0000 On Mon, 03 Feb 2014 09:22:32 +0100 Koop Mast wrote: > On 3-2-2014 4:19, jhellenthal@dataix.net wrote: >> Could someone please get rid of the '$' here ? >> >> THanks >> >> make: "/export/usr/ports/x11/pixman/Makefile" line 23: Malformed conditional (! ${MACHINE_CPU:Mmmx}) >> make: "/export/usr/ports/x11/pixman/Makefile" line 26: Malformed conditional (! ${MACHINE_CPU:Msse2}) > > We can't get rid of the '$' here they are needed. Can you tell me on > which arch this happens? > make -V ARCH or uname -a output. For anything non-x86 if you set CPUTYPE in make.conf, MACHINE_CPU isn't always defined in bsd.cpu.mk. That's probably a bug in bsd.cpu.mk. In this case I think it's best to remove the SIMD option. The configure script detects if the compiler supports it and at runtime pixman detects if the cpu supports it. There's no need to disable this. There's also SSSE3 and several mips and arm options that are missing, so the pixman package already has support for those: checking whether to use MMX intrinsics... disabled checking whether to use SSE2 intrinsics... disabled checking whether to use SSSE3 intrinsics... yes Index: Makefile =================================================================== --- Makefile (revision 342362) +++ Makefile (working copy) @@ -14,18 +14,4 @@ USE_AUTOTOOLS= libtool CONFIGURE_ARGS= --disable-gtk USE_GNOME= ltverhack:30 -OPTIONS_DEFINE= SIMD - -.include - -.if ! {PORT_OPTIONS:MSIMD} -CONFIGURE_ARGS= --disable-vmx --disable-arm-simd -. if ! ${MACHINE_CPU:Mmmx} -CONFIGURE_ARGS+= --disable-mmx -. endif -. if ! ${MACHINE_CPU:Msse2} -CONFIGURE_ARGS+= --disable-sse2 -. endif -.endif - .include