From owner-cvs-src@FreeBSD.ORG Mon Jan 10 20:06:52 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB57916A4CE; Mon, 10 Jan 2005 20:06:52 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F49643D39; Mon, 10 Jan 2005 20:06:52 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.12] (g4.samsco.home [192.168.254.12]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id j0AKAIDP041065; Mon, 10 Jan 2005 13:10:18 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <41E2E059.5070106@freebsd.org> Date: Mon, 10 Jan 2005 13:06:49 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040514 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John-Mark Gurney References: <200501061745.j06Hj344034786@repoman.freebsd.org> <20050110184139.GE19624@funkthat.com> In-Reply-To: <20050110184139.GE19624@funkthat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Maksim Yevmenkin cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netgraph ng_base.c src/sys/sys kernel.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2005 20:06:52 -0000 John-Mark Gurney wrote: > Maksim Yevmenkin wrote this message on Thu, Jan 06, 2005 at 17:45 +0000: > >> This does not address the bigger problem: MODULE_DEPEND >> does not seem to work when modules are compiled in the >> kernel, but it fixes the problem with Netgraph Bluetooth >> device drivers reported by a few folks. > > > The real problem is that MODULE_DEPEND only documents other kernel > dependancies, but does not reorder SYSINIT's... Considering that > SYSINIT's are always suppose to be ordered properly (otherwise, what > is the point of SYSINIT's) when staticly linked, having SYSINIT's not > properly ordered is the only bug... > > If we move to a more complex and module aware system of SYSINIT's, then > it might happen, but this will be very difficult considering that when > staticly linked, you have no way to seperate which SYSINIT's belong to > which modules... > > So, to everone, MODULE_DEPEND only marks which modules are required > for this module to work, it does not infulence startup ordering at > all... > You hit it on the head, and this is why I recommended the solution that Maksim used. 'Fixing' everything so that MODULE_DEPEND influenced SI_SUB and SI_ORDER would be an incredibly huge undertaking. ng_base really isn't a driver anyways, it's a piece of infrastructure that drivers rely on. It's like saying that if.c is a driver. The only thing to watch out for with this commit is for future coders to understand that SI_SUB_NETGRAPH is _only_ for ng_base, not for netgraph drivers. Scott