From owner-freebsd-net@FreeBSD.ORG Wed Mar 14 15:02:12 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7A5DB16A400 for ; Wed, 14 Mar 2007 15:02:12 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 385DC13C459 for ; Wed, 14 Mar 2007 15:02:12 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l2EF1dL8057372; Wed, 14 Mar 2007 10:01:39 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l2EF1cuZ057371; Wed, 14 Mar 2007 10:01:38 -0500 (CDT) (envelope-from brooks) Date: Wed, 14 Mar 2007 10:01:38 -0500 From: Brooks Davis To: Yar Tikhiy Message-ID: <20070314150138.GC56444@lor.one-eyed-alien.net> References: <20070314102023.GB1766@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WplhKdTI2c8ulnbP" Content-Disposition: inline In-Reply-To: <20070314102023.GB1766@comp.chem.msu.su> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Wed, 14 Mar 2007 10:01:39 -0500 (CDT) Cc: freebsd-net@freebsd.org Subject: Re: Generic ioctl and ether_ioctl don't agree X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2007 15:02:12 -0000 --WplhKdTI2c8ulnbP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 14, 2007 at 01:20:23PM +0300, Yar Tikhiy wrote: > Hi folks, >=20 > Quite a while ago I noticed that our ioctl handlers get the ioctl > command via u_long, but ether_ioctl()'s command argument is int. > This disarray dates back to 1998, when ioctl functions started to > take u_long as the command, but ether_ioctl() was never fixed. > Fortunately, our ioctl command coding still fits in 32 bits, or > else we would've got problems on 64-bit arch'es already. I'd like > to fix this long-standing bug some day after RELENG_7 is branched. > Of course, this will break ABI to network modules on all 64-bit > arch'es. BTW, the same applies to other L2 layers, such as firewire, > which seems to have been cloned from if_ethersubr.c. >=20 > Any objections or comments? Thanks! Why wait? We're allowed to break module ABIs in current at any time and there's no chance modules built on RELENG_6 will work on RELENG_7 trees anyway. -- Brooks --WplhKdTI2c8ulnbP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF+A5SXY6L6fI4GtQRAllSAJ46pjNPXUmgW75ecpgONqRNdpBKHQCgqbBf cL6E8d7By1TIU8h3sfgyvzk= =sbzp -----END PGP SIGNATURE----- --WplhKdTI2c8ulnbP--