From nobody Tue Mar 18 05:02:27 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZH0832spGz5rGdM; Tue, 18 Mar 2025 05:02:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZH08322nXz3qBp; Tue, 18 Mar 2025 05:02:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742274147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0b23t+9lYbDPRjLDhJC4bDNsomXU1Eu94HYsHVsik9w=; b=p1FCO9Dq8hQZVHihb3sXdRzxRcLk/PQLxOl+eXANjjuFQebZW75X/2/N9FBO3QWMnLHvtH VxXbS1x24o0DkmrZmFGsRn0XDwo0L/HUu9zCoyXIw6fxbNxlpXOIuNtD/cvHK7tgQPJLhV bWyHceFboGPUJwdW49ywBR7cwEg9vkSrA0RFA7sxjHz/4GQQugn+b1ofpK/Sj9qXHeEo// o+cFeWQzoAzt+odfT4V1m++EMr1FLaGKaOD5vvbW2QS9+u33CXlCSFgjvezKy8BZWOBJkF 08cGzqEZsKxVOvvEqZaOyJK8rNWlV/0pwW4AxeoExnP5zaK1jlH0H+MmWnAUBQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742274147; a=rsa-sha256; cv=none; b=JLqvon/qAYp7lPaXoAkPBrrX4lhL5/DZ4JE+Hv+YNqzUH3fgr0LGbnyS2a9i2yxkuB8XaN Xx7eJ5uk4oiSw+fg8vshs+XkugkPONlqJ/edukwlSf8AUFcu80x/ScivzTV9GgYkULEh0Y nOZxIwYw92xKpsxu+us4fYrx6NmHaHqZ74ViejbNzsUqRwT77VB55bmy575B8YVAn5ZyQv m0VMm3gJNfgCx3mGC/4equMbqqbwl67UzemU+Ourq2ES1NYVRQJ0Cfoeaty36pS4d2MuZ7 Q0i+aHecFFMveSztyG/fUVQAtkCOoVxCbT4L0hMOT0YLXxoRVfI2FcRvvaQIYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742274147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0b23t+9lYbDPRjLDhJC4bDNsomXU1Eu94HYsHVsik9w=; b=jcaqSUYLex3IzJHZT4lXGmfNfVQ7XHFTLCxT+eLZG6qwBqr/R2GLOXxGa52TyTsOHfZvkH 7Klx3SzWBpPBq13SxG9Lc8STbknvLMCqr6V615GrWNN/24dHdb+e7uVSeAkTe0ryOmSLO6 SidWJ5MaanNRQLy/wEhTBcSIuORPy0O2EryBfjwk6p2OQlUmQGQV33c3zjB93QGkVP3d7f KFF9LJyWJ264fDmKXkCtLkcw3BMftag+On0flYmcBEi3frVkliYxQtwnilpytnsSoi3gUH OX4/EsBCktxokBWcQOceS6YfQff4eobS1N5rdwklcXu2F1jk6nUNrJA8N4vj8g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZH0831YgVz3kZ; Tue, 18 Mar 2025 05:02:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52I52Rop089673; Tue, 18 Mar 2025 05:02:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52I52Rrn089670; Tue, 18 Mar 2025 05:02:27 GMT (envelope-from git) Date: Tue, 18 Mar 2025 05:02:27 GMT Message-Id: <202503180502.52I52Rrn089670@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Wei Hu Subject: git: 64610df59348 - stable/14 - mana: remove redundant doorbell in mana_poll_rx_cq() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: whu X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 64610df59348c5f72fcca56b46a4a2909b41c471 Auto-Submitted: auto-generated The branch stable/14 has been updated by whu: URL: https://cgit.FreeBSD.org/src/commit/?id=64610df59348c5f72fcca56b46a4a2909b41c471 commit 64610df59348c5f72fcca56b46a4a2909b41c471 Author: Wei Hu AuthorDate: 2025-03-14 05:26:45 +0000 Commit: Wei Hu CommitDate: 2025-03-18 04:53:56 +0000 mana: remove redundant doorbell in mana_poll_rx_cq() With the last commit to refill the rx mbuf in batch, the doorbell in mana_poll_rx_cq() becomes redundant. Remove it to save a few microseconds spent in mmio call. Reported by: NetApp Reviewed by: Tallamraju, Sai Tested by: whu Fixes: 9b8701b8 ("mana: refill the rx mbuf in batch") MFC after: 3 days Sponsored by: Microsoft (cherry picked from commit 47f4137e44b8079c7784604d220a298db07a19a1) --- sys/dev/mana/mana_en.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/dev/mana/mana_en.c b/sys/dev/mana/mana_en.c index 1df5419e6c64..9eeaec11d1b2 100644 --- a/sys/dev/mana/mana_en.c +++ b/sys/dev/mana/mana_en.c @@ -1890,13 +1890,6 @@ mana_poll_rx_cq(struct mana_cq *cq) mana_process_rx_cqe(cq->rxq, cq, &comp[i]); } - if (comp_read > 0) { - struct gdma_context *gc = - cq->rxq->gdma_rq->gdma_dev->gdma_context; - - mana_gd_wq_ring_doorbell(gc, cq->rxq->gdma_rq); - } - tcp_lro_flush_all(&cq->rxq->lro); }