From owner-p4-projects@FreeBSD.ORG  Fri Aug 29 04:52:18 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5D8BD1065672; Fri, 29 Aug 2008 04:52:18 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 20DD4106566C
	for <perforce@FreeBSD.org>; Fri, 29 Aug 2008 04:52:18 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id E90C38FC0A
	for <perforce@FreeBSD.org>; Fri, 29 Aug 2008 04:52:17 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7T4qHbJ054675
	for <perforce@FreeBSD.org>; Fri, 29 Aug 2008 04:52:17 GMT
	(envelope-from ed@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7T4qHto054673
	for perforce@freebsd.org; Fri, 29 Aug 2008 04:52:17 GMT
	(envelope-from ed@FreeBSD.org)
Date: Fri, 29 Aug 2008 04:52:17 GMT
Message-Id: <200808290452.m7T4qHto054673@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	ed@FreeBSD.org using -f
From: Ed Schouten <ed@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 148775 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Aug 2008 04:52:18 -0000

http://perforce.freebsd.org/chv.cgi?CH=148775

Change 148775 by ed@ed_dull on 2008/08/29 04:51:45

	Small typo in snp -- not really incorrect, but sloppy.
	
	Don't use a while-loop to check the value of uio->uio_resid.
	
	Reported by:	Sam Banks

Affected files ...

.. //depot/projects/mpsafetty/sys/dev/snp/snp.c#13 edit

Differences ...

==== //depot/projects/mpsafetty/sys/dev/snp/snp.c#13 (text+ko) ====

@@ -141,7 +141,7 @@
 	struct snp_softc *ss;
 	struct tty *tp;
 
-	while (uio->uio_resid == 0)
+	if (uio->uio_resid == 0)
 		return (0);
 
 	error = devfs_get_cdevpriv((void **)&ss);