From owner-cvs-all Mon Nov 26 8:41:46 2001 Delivered-To: cvs-all@freebsd.org Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by hub.freebsd.org (Postfix) with ESMTP id 6D30537B416; Mon, 26 Nov 2001 08:41:39 -0800 (PST) Received: from scsiguy.com (localhost [127.0.0.1]) by aslan.scsiguy.com (8.11.5/8.11.5) with ESMTP id fAQGfVY45664; Mon, 26 Nov 2001 09:41:31 -0700 (MST) (envelope-from gibbs@scsiguy.com) Message-Id: <200111261641.fAQGfVY45664@aslan.scsiguy.com> To: Ian Dowse Cc: ken@kdm.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c In-Reply-To: Your message of "Mon, 26 Nov 2001 16:38:12 GMT." <200111261638.aa78493@salmon.maths.tcd.ie> Date: Mon, 26 Nov 2001 09:41:31 -0700 From: "Justin T. Gibbs" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >>If you look in the PR, the controller properly reports that the >>sync cache command is unsupported. Quirks should only be used >>for devices that catastrophically fail when a sync cache command >>is sent. This also gives us the oportunity to *fix* whatever is >>wrong with the code in the da driver that should silenty accept >>a properly rejected sync cache command. I've looked at the code > >Sorry, I must have missed your message in the audit-trail for that >PR where you say basically the same thing. The PR is quite old; >maybe the problem has been fixed since? > >Anyway, I'll back out that change and ask the submitter for >more information. Are there any other devices you're aware >of that exibit this behaviour which I might be able to try? I would say that perhaps 75% or more of our sync cache quirk entries fall into this category. Very few devices catastrophically fail. I don't recall off-hand which entries I've complained about in the past. Perhaps Ken will remember. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message