From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Apr 27 15:40:03 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6AC7D2B5 for ; Sun, 27 Apr 2014 15:40:03 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2D5DF120 for ; Sun, 27 Apr 2014 15:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s3RFe3X3090047 for ; Sun, 27 Apr 2014 15:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s3RFe2LM090046; Sun, 27 Apr 2014 15:40:02 GMT (envelope-from gnats) Resent-Date: Sun, 27 Apr 2014 15:40:02 GMT Resent-Message-Id: <201404271540.s3RFe2LM090046@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "A.J. van Werven" Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B67D9251 for ; Sun, 27 Apr 2014 15:34:46 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A2BCBEB for ; Sun, 27 Apr 2014 15:34:46 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s3RFYkTh097921 for ; Sun, 27 Apr 2014 15:34:46 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s3RFYjEn097908; Sun, 27 Apr 2014 15:34:45 GMT (envelope-from nobody) Message-Id: <201404271534.s3RFYjEn097908@cgiserv.freebsd.org> Date: Sun, 27 Apr 2014 15:34:45 GMT From: "A.J. van Werven" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/189050: [PATCH] games/oneko fails to build with Clang X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Apr 2014 15:40:03 -0000 >Number: 189050 >Category: ports >Synopsis: [PATCH] games/oneko fails to build with Clang >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Apr 27 15:40:02 UTC 2014 >Closed-Date: >Last-Modified: >Originator: A.J. van Werven >Release: 9.1-RELEASE-p3 >Organization: >Environment: >Description: The games/oneko port fails to build on FreeBSD 9.1-RELEASE-p3/amd64, if Clang is used as the compiler. The function NekoChangeVisibility() in event.c does not have a return type specified. It is therefore assumed to return int, while it doesn't actually return anything. Explicitly specifying this function to be of type void fixes the problem. >How-To-Repeat: # portmaster games/oneko (On a system that uses Clang, I didn't try with GCC.) >Fix: Apply the supplied patch to event.c. Please note: the port's Makefile explicitly specifies a do-patch target, so the Makefile will probably have to be updated as well, in order to make sure the patch actually gets applied. Patch attached with submission follows: --- event.c.bak 2014-04-27 16:54:53.000000000 +0200 +++ event.c 2014-04-27 16:55:20.000000000 +0200 @@ -230,6 +230,7 @@ } #endif /* SENDER */ +void NekoChangeVisibility(window) Window window; { >Release-Note: >Audit-Trail: >Unformatted: