From owner-freebsd-mips@FreeBSD.ORG Wed Apr 28 11:57:24 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D55F1065672; Wed, 28 Apr 2010 11:57:24 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from lakerest.net (unknown [IPv6:2001:240:585:2:213:d4ff:fef3:2d8d]) by mx1.freebsd.org (Postfix) with ESMTP id 1946D8FC1F; Wed, 28 Apr 2010 11:57:23 +0000 (UTC) Received: from [10.1.1.53] ([10.1.1.53]) (authenticated bits=0) by lakerest.net (8.14.3/8.14.3) with ESMTP id o3SBvJ57019264 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 28 Apr 2010 07:57:20 -0400 (EDT) (envelope-from rrs@lakerest.net) DKIM-Signature: a=rsa-sha1; c=simple/simple; d=lakerest.net; s=mail; t=1272455840; h=Cc:Message-Id:From:To:In-Reply-To:Content-Type: Content-Transfer-Encoding:Mime-Version:Subject:Date:References: X-Mailer; b=DOPQpivT+rjk2CbVHZetjdC8qnBpNPvQmhIX0r9amdN3EZqu8OtmRqI 2QS9YPAjG23/nkZ7ce86GIoh7SO6COQ== Message-Id: <921B6E11-9919-4674-B7A2-71EB3A22B2EB@lakerest.net> From: Randall Stewart To: Rui Paulo In-Reply-To: <13B981BB-EDB1-4D39-A9CA-A1D4981E5732@freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Date: Wed, 28 Apr 2010 04:57:19 -0700 References: <13B981BB-EDB1-4D39-A9CA-A1D4981E5732@freebsd.org> X-Mailer: Apple Mail (2.936) Cc: freebsd-mips@freebsd.org Subject: Re: [PATCH] Account RMI XLR interrupts X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2010 11:57:24 -0000 Rui: Let me commit the whole works when I get back to CA.. That won't be until a week from Sunday... unless your desperate to get this in.. I was hoping to get to the bottom of the other SMP crash I see before dumping all of JC's patches in.. But if you need this badly enough go ahead... R On Apr 28, 2010, at 4:28 AM, Rui Paulo wrote: > > On 20 Apr 2010, at 12:36, Rui Paulo wrote: > >> Hi, >> The following patch accounts interrupts on the XLR and makes vmstat >> -i and systat work display useful data. I think the commented out >> atomic inc can go away, but I'm not sure. >> >> Here's an example: >> >> $ vmstat -i >> interrupt total rate >> int16: 56118 984 >> int17: 214 3 >> Total 56332 988 >> >> int16 is the timer and int17 is the network interface (rge1). >> >> Index: intr_machdep.c >> =================================================================== >> --- intr_machdep.c (revision 206791) >> +++ intr_machdep.c (working copy) >> @@ -157,28 +157,17 @@ >> for (i = sizeof(eirr) * 8 - 1; i >= 0; i--) { >> if ((eirr & (1ULL << i)) == 0) >> continue; >> ie = mips_intr_events[i]; >> /* atomic_add_long(mih->cntp, 1); */ >> + /* Don't account special IRQs */ >> + switch (i) { >> + case IRQ_IPI: >> + case IRQ_MSGRING: >> + break; >> + default: >> + mips_intrcnt_inc(mips_intr_counters[i]); >> + } >> >> write_c0_eirr64(1ULL << i); >> pic_ack(i, 0); >> > > Can I commit this? > > Regards, > -- > Rui Paulo > > > _______________________________________________ > freebsd-mips@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-mips > To unsubscribe, send any mail to "freebsd-mips- > unsubscribe@freebsd.org" > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)