From owner-freebsd-net@freebsd.org Fri Mar 20 03:45:06 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 884A72594D9 for ; Fri, 20 Mar 2020 03:45:06 +0000 (UTC) (envelope-from neel@neelc.org) Received: from rainpuddle.neelc.org (rainpuddle.neelc.org [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48k8md2dCTz4fgP for ; Fri, 20 Mar 2020 03:45:04 +0000 (UTC) (envelope-from neel@neelc.org) Received: from mail.neelc.org (rainpuddle.neelc.org [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622]) by rainpuddle.neelc.org (Postfix) with ESMTPSA id 14D47B1FBF for ; Thu, 19 Mar 2020 20:45:01 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 19 Mar 2020 20:44:59 -0700 From: Neel Chauhan To: freebsd-net@freebsd.org Subject: Reviewing three ipfw(8) patches User-Agent: Roundcube Webmail/1.4.1 Message-ID: X-Sender: neel@neelc.org X-Rspamd-Queue-Id: 48k8md2dCTz4fgP X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=none) header.from=neelc.org; spf=pass (mx1.freebsd.org: domain of neel@neelc.org designates 2001:19f0:8001:fed:5400:2ff:fe73:c622 as permitted sender) smtp.mailfrom=neel@neelc.org X-Spamd-Result: default: False [-5.98 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.94)[-0.944,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.99)[-0.990,0]; IP_SCORE(-3.34)[ip: (-9.82), ipnet: 2001:19f0:8000::/38(-4.91), asn: 20473(-1.93), country: US(-0.05)]; DMARC_POLICY_ALLOW(-0.50)[neelc.org,none]; RCVD_COUNT_ONE(0.00)[1]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:20473, ipnet:2001:19f0:8000::/38, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; ONCE_RECEIVED(0.10)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2020 03:45:06 -0000 Hi freebsd-net@, I'm not sure if this mailing list is the right place to ask for code review. If not, could you please direct me to the right mailing list? I have three patches for ipfw(8) below: * https://reviews.freebsd.org/D24011 (ipfw: Support {w:x:y::z}:port (bracketed) IPv6 addresses in the fwd command) * https://reviews.freebsd.org/D23888 (ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups) * https://reviews.freebsd.org/D24021 (ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()) Could someone please review them and commit if they are okay? -Neel === https://www.neelc.org/