From nobody Sun Sep 22 04:06:07 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XBCGm1ZVDz5XCg0; Sun, 22 Sep 2024 04:06:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XBCGm0zZLz4m8l; Sun, 22 Sep 2024 04:06:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726977968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fb7o0ytNuogvGIh4/bbI8c6gNf/n5BEAApHrt3jdBdE=; b=gpVC+i7Kwjib8EdTt7h9VTNUaPNOsD2MBe9L40ySUv+z5Y2cwgDQGVxeFJQP/qHn03bU0U WtaUEoTa8wn/Lx4NChKeG26eDCDwTrLCzQBw5Bs5MwezODpzjuDbRVf0O7eLNWXH/Pa+sm +CpnZJPsprbmyI2rYR81X88Ca4cmsdnXx/LM6mwhoW5N1mtQY0PTqUp8kzgvKHAzkoEPs0 Pmac1mtcprg2Jw3DeLHDVbeNKiI4263fixZu9cbHHyDZObG2+xvh3H5I9RxBQ8cZP5EUbm 9/6LDjERJ+mZ6elrzcBNb5IHQ1GvtQg8KxOG4AMTYGGbBqG7EkcBITP5opXcZg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726977968; a=rsa-sha256; cv=none; b=hX5YjqPNXE8S4aj7mfvOqwW7r2TPOXqfnYebshnPy1Rmc+MRhf3kAgHCLOACAFFCo66vzw 0FGe7Uk5ucJjRijjGq7KPYpBgX8mdMyYa+XArViMXHgB1zm5QL37Fcsf8avFUTds4BfVp8 nsBHN/treRvwfh3TJtSsndXhqv8pJ2xp+RWRDFc6uRGpBZ98yxxTwA2n1Cz7dBUE8UuzlM ouPBiLELYszC475MBuhPKPpowc1A/qijsZYRK9kI5Mmy89UbauAN0BfH8+pYJQ7XFy49Fh jH1t1xOwXDz2EzZNKuMFZ6bIFE2z+hxymhhKzP5EKUa2ENbZonwXpTSG1H5x1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726977968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fb7o0ytNuogvGIh4/bbI8c6gNf/n5BEAApHrt3jdBdE=; b=j3atOoQa4BDqAirxsuSXi/KLxdtcLQ3DzZvbafAJeik3muWtZsVUxAJsdVQ4VOxmMU7kBh iCm86tm/cyTsvyrnKnagv0Q74wu+7w6QJ8XxejftQRqOKqzhKtf/CfU44g4UIwZoS02VMA nWnv0WMoc+KR+V1rh/AmbexvCwM/0ee3Nrpz98q8penuZSRy54NzczpndyndA1Vs2dRolJ h4o5DgFd0+WG1aqA+QP2ENEvpBL+NeaSSXi/hE/3jA3TuVhj6qZtclpBlWsiCQ181QrFt6 KTYRMvHP1tKtgxbBund6VGPYxIC1fruyjkkwpUeRmDZLbPDW5nop7cfdnZXl+A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XBCGm0Zr9z11sj; Sun, 22 Sep 2024 04:06:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48M467MI040580; Sun, 22 Sep 2024 04:06:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48M4674I040577; Sun, 22 Sep 2024 04:06:07 GMT (envelope-from git) Date: Sun, 22 Sep 2024 04:06:07 GMT Message-Id: <202409220406.48M4674I040577@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: c11a0649b972 - main - e1000: drop NEEDGIANT on em_sysctl_reg_handler uses List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c11a0649b97281699e39d0fc82818f235c1dfb87 Auto-Submitted: auto-generated The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=c11a0649b97281699e39d0fc82818f235c1dfb87 commit c11a0649b97281699e39d0fc82818f235c1dfb87 Author: Kevin Bowling AuthorDate: 2024-09-22 04:04:38 +0000 Commit: Kevin Bowling CommitDate: 2024-09-22 04:04:38 +0000 e1000: drop NEEDGIANT on em_sysctl_reg_handler uses These are simple singular diagnostic register reads MFC after: 1 week --- sys/dev/e1000/if_em.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 768522a821bd..8d140979fbcd 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -4433,11 +4433,11 @@ em_add_hw_stats(struct e1000_softc *sc) CTLFLAG_RD, &sc->watchdog_events, "Watchdog timeouts"); SYSCTL_ADD_PROC(ctx, child, OID_AUTO, "device_control", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_CTRL, em_sysctl_reg_handler, "IU", "Device Control Register"); SYSCTL_ADD_PROC(ctx, child, OID_AUTO, "rx_control", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_RCTL, em_sysctl_reg_handler, "IU", "Receiver Control Register"); SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "fc_high_water", @@ -4455,11 +4455,11 @@ em_add_hw_stats(struct e1000_softc *sc) queue_list = SYSCTL_CHILDREN(queue_node); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "txd_head", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_TDH(txr->me), em_sysctl_reg_handler, "IU", "Transmit Descriptor Head"); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "txd_tail", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_TDT(txr->me), em_sysctl_reg_handler, "IU", "Transmit Descriptor Tail"); SYSCTL_ADD_ULONG(ctx, queue_list, OID_AUTO, "tx_irq", @@ -4475,11 +4475,11 @@ em_add_hw_stats(struct e1000_softc *sc) queue_list = SYSCTL_CHILDREN(queue_node); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "rxd_head", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_RDH(rxr->me), em_sysctl_reg_handler, "IU", "Receive Descriptor Head"); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "rxd_tail", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_RDT(rxr->me), em_sysctl_reg_handler, "IU", "Receive Descriptor Tail"); SYSCTL_ADD_ULONG(ctx, queue_list, OID_AUTO, "rx_irq",