From owner-svn-ports-all@FreeBSD.ORG  Sat Oct  6 22:25:05 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 436CC1065673
	for <svn-ports-all@freebsd.org>; Sat,  6 Oct 2012 22:25:05 +0000 (UTC)
	(envelope-from bsd-src@helfman.org)
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
	[209.85.212.178])
	by mx1.freebsd.org (Postfix) with ESMTP id B6F428FC17
	for <svn-ports-all@freebsd.org>; Sat,  6 Oct 2012 22:25:04 +0000 (UTC)
Received: by mail-wi0-f178.google.com with SMTP id hr7so1696158wib.13
	for <svn-ports-all@freebsd.org>; Sat, 06 Oct 2012 15:25:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:x-gm-message-state;
	bh=UonhckAsMvaifM19Br5jq3AtT3Atj/7MEpBTp+OtIg8=;
	b=cK/TKQN2iDcxwbZ1g8UtorhW6tvYJ8uCsaM3ID7ku8ZDa7vE3TJB+QudXCAoe8/die
	80514p4yp/WcGrGDjwJ1yU0XvkrIXSpyzyJTS9++8oVGtFrz1AdIx698xfUZFHr8PYw8
	smFxSJCUKSO0dlDaEGjOG2oQDtizSnqi6D+TtzRE/RCmy34Y+EHlzL4AMf++N/KOkAJK
	zXeL40ETZFGuDp0D2OolrbUgan95UCxEBXBr0yUrPBLoLp8heNMydQEqPypBA7/YWMNL
	X4wwsgCIkN6lSjEFkEFAqFQ7HPMwon8/TdQEWAFXAW+gnFfpr+KZptShAuae3NhR8V/T
	o3/A==
MIME-Version: 1.0
Received: by 10.216.193.220 with SMTP id k70mr7868903wen.35.1349562303371;
	Sat, 06 Oct 2012 15:25:03 -0700 (PDT)
Sender: bsd-src@helfman.org
Received: by 10.194.81.136 with HTTP; Sat, 6 Oct 2012 15:25:03 -0700 (PDT)
In-Reply-To: <5070A09B.1090404@FreeBSD.org>
References: <201210060537.q965bUpk005984@svn.freebsd.org>
	<5070A09B.1090404@FreeBSD.org>
Date: Sat, 6 Oct 2012 15:25:03 -0700
X-Google-Sender-Auth: gWxtYEehb7rhIkC3kC07BNyR-sw
Message-ID: <CAMuy=+iTW7AgjW1QGjS9n9E5hXfwLwq=kKxmBSia2nDKs_-9-g@mail.gmail.com>
From: Jason Helfman <jgh@FreeBSD.org>
To: Doug Barton <dougb@freebsd.org>
X-Gm-Message-State: ALoCoQnfNnZXpo9zUuE7xs3FZ4FoaYMNF1BjcReE6tfWbD5HlfXtD/TZRzPQNC99EhFg6+jGkgwI
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, nemysis@gmx.ch,
	ports-committers@freebsd.org
Subject: Re: svn commit: r305338 - in head/games/pycadia: . files
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Oct 2012 22:25:05 -0000

On Sat, Oct 6, 2012 at 2:20 PM, Doug Barton <dougb@freebsd.org> wrote:

> On 10/05/2012 22:37, Jason Helfman wrote:
> > Added: head/games/pycadia/files/pycadia.sh.in
> >
> ==============================================================================
> > --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> > +++ head/games/pycadia/files/pycadia.sh.in    Sat Oct  6 05:37:29 2012
>        (r305338)
> > @@ -0,0 +1,6 @@
> > +#!/bin/sh
> > +#
> > +# $FreeBSD$
> > +
> > +cd "%%DATADIR%%"
> > +./pycadia.py
>
> Unless there is some reason to cd into that directory, you'd be better
> off with just: %%DATADIR%%/pycadia.py
>
> And in any case, shouldn't you be using exec here?
>

I can check with the maintainer, but it does need to be run from the
DATADIR specifically.
What would exec provide that isn't currently fulfilled?

Thanks

-jgh