From owner-svn-src-head@freebsd.org  Sun Sep 20 20:37:51 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C74F6A06965;
 Sun, 20 Sep 2015 20:37:51 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "mailhost.stack.nl",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 903AE1D72;
 Sun, 20 Sep 2015 20:37:51 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mx1.stack.nl (Postfix) with ESMTP id E784F3592ED;
 Sun, 20 Sep 2015 22:37:47 +0200 (CEST)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id A0EF528494; Sun, 20 Sep 2015 22:37:47 +0200 (CEST)
Date: Sun, 20 Sep 2015 22:37:47 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: Craig Rodrigues <rodrigc@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r288026 - head/lib/libc/stdlib
Message-ID: <20150920203747.GA53002@stack.nl>
References: <201509202015.t8KKFjaN075016@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201509202015.t8KKFjaN075016@repo.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Sep 2015 20:37:51 -0000

On Sun, Sep 20, 2015 at 08:15:45PM +0000, Craig Rodrigues wrote:
> Author: rodrigc
> Date: Sun Sep 20 20:15:44 2015
> New Revision: 288026
> URL: https://svnweb.freebsd.org/changeset/base/288026

> Log:
>   Remove names from prototypes

> Modified:
>   head/lib/libc/stdlib/atexit.c
>   head/lib/libc/stdlib/heapsort.c
>   head/lib/libc/stdlib/merge.c
> [snip patch]

Although style(9) does not mention userland implementation files
explicitly, I think it is OK to use parameter names for them, for the
extra information. Since these are not header files visible to
applications, protected names (_foo) are not necessary.

I wouldn't commit a change that only either adds or removes parameter
names in prototypes myself, except to a header file visible to
applications (to fix namespace pollution).

-- 
Jilles Tjoelker