Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 20 Sep 2015 22:37:47 +0200
From:      Jilles Tjoelker <jilles@stack.nl>
To:        Craig Rodrigues <rodrigc@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r288026 - head/lib/libc/stdlib
Message-ID:  <20150920203747.GA53002@stack.nl>
In-Reply-To: <201509202015.t8KKFjaN075016@repo.freebsd.org>
References:  <201509202015.t8KKFjaN075016@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 20, 2015 at 08:15:45PM +0000, Craig Rodrigues wrote:
> Author: rodrigc
> Date: Sun Sep 20 20:15:44 2015
> New Revision: 288026
> URL: https://svnweb.freebsd.org/changeset/base/288026

> Log:
>   Remove names from prototypes

> Modified:
>   head/lib/libc/stdlib/atexit.c
>   head/lib/libc/stdlib/heapsort.c
>   head/lib/libc/stdlib/merge.c
> [snip patch]

Although style(9) does not mention userland implementation files
explicitly, I think it is OK to use parameter names for them, for the
extra information. Since these are not header files visible to
applications, protected names (_foo) are not necessary.

I wouldn't commit a change that only either adds or removes parameter
names in prototypes myself, except to a header file visible to
applications (to fix namespace pollution).

-- 
Jilles Tjoelker



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150920203747.GA53002>