Date: Tue, 20 Jan 2015 13:47:36 +0300 From: Slawa Olhovchenkov <slw@zxy.spb.ru> To: Hans Petter Selasky <hps@selasky.org> Cc: Adrian Chadd <adrian@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, Jason Wolfe <nitroboost@gmail.com>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: [RFC] kern/kern_timeout.c rewrite in progress Message-ID: <20150120104736.GA78629@zxy.spb.ru> In-Reply-To: <54BE03EB.2070604@selasky.org> References: <CAJ-Vmo=tc-hqykhyc5bQW8qd_34PZU6yfGY8wziByA0xnR3ANQ@mail.gmail.com> <54A9A71E.70609@selasky.org> <CAAAm0r39Sv3TCvwaCiNQ1Y9iBVtY_nb0A_iNOC41bgxqXmt%2B4w@mail.gmail.com> <54B29A49.3080600@selasky.org> <CAAAm0r2eNYicq%2BKKj5f5EE%2BKLPxdvy15wj1ZWS=zA6sgOtcoGQ@mail.gmail.com> <54B67DA7.3070106@selasky.org> <54B7DECF.8070209@selasky.org> <CAAAm0r0S=s8pRHR3-h%2BntEt27cw6tshHCONSezaAr3zBhLhSWA@mail.gmail.com> <54BADFB3.3030405@selasky.org> <54BE03EB.2070604@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 20, 2015 at 08:29:47AM +0100, Hans Petter Selasky wrote: > On 01/17/15 23:18, Hans Petter Selasky wrote: > > On 01/17/15 20:11, Jason Wolfe wrote: > >> > >> HPS, > >> > >> Just to give a quick status update, this patch has most certainly > >> resolved our spin lock held too long panics on stable/10. > >> > >> Thank you to JHB for spending some time digging into the issue and > >> leading us to td_slpcallout as the culprit, and HPS for your rewrite. > >> I had heard rumors of other being affected by similar issues, so this > >> seems like a fine candidate for an MFC if possible. > >> > >> Jason > >> > > > > Hi Jason, > > > > I'm glad to hear that my patch has resolved your issue and I'm happy we > > now have a more stable system. > > > > It was actually a co-worker at work which wrote some bad code which I > > started debugging which then lead me to look at the callout subsystem. > > One bug kills the other ;-) > > > > I'm planning a MFC to 10-stable - yes, and will possibly add the > > _callout_stop_safe() function to not break binary compatibility with > > existing drivers as part of the MFC. > > > > --HPS > > Hi, > > Here is a followup patch for the TCP stack like I mentioned in the > beginning of the work done on the callout subsystem: > > https://reviews.freebsd.org/D1563 > > If someone has a setup for massive TCP testing please give it a spin. I have on 10.1 (with applied r261906).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150120104736.GA78629>