From owner-freebsd-current Sun May 31 23:04:16 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA07463 for freebsd-current-outgoing; Sun, 31 May 1998 23:04:16 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from cerebus.nectar.com (cerebus.nectar.com [204.27.67.90]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA07458 for ; Sun, 31 May 1998 23:04:14 -0700 (PDT) (envelope-from nectar@cerebus.nectar.com) Received: from cerebus.nectar.com (localhost.communique.net [127.0.0.1]) by cerebus.nectar.com (8.8.8/8.8.8) with ESMTP id BAA27766; Mon, 1 Jun 1998 01:03:59 -0500 (CDT) Message-Id: <199806010603.BAA27766@cerebus.nectar.com> X-PGP-RSAfprint: 00 F9 E6 A2 C5 4D 0A 76 26 8B 8B 57 73 D0 DE EE X-PGP-RSAkey: http://pgp.ai.mit.edu:11371/pks/lookup?op=get&search=0x094724A9 From: Jacques Vidrine In-reply-to: <199806010524.PAA09745@godzilla.zeta.org.au> References: <199806010524.PAA09745@godzilla.zeta.org.au> Subject: Re: union nethostaddr no longer defined for src/sbin/mount_nfs.c To: Bruce Evans Cc: freebsd-current@FreeBSD.ORG Date: Mon, 01 Jun 1998 01:03:59 -0500 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG -----BEGIN PGP SIGNED MESSAGE----- You'd have to also back out revision 1.27 of src/sbin/mount_nfs.c of the same date. If a structure needs to be visible to userland utilities, it shouldn't be in a KERNEL section, IMHO. For that matter, I sometimes think there ought to be more header.h/headervar.h pairs instead of #ifdef KERNEL everywhere. I guess the question in my mind is which is more important with regards to the NFS code: * Progress towards a less ``polluted'' environment, OR * Kernel and header source code compatibility with other BSD systems Jacques Vidrine On 1 June 1998 at 15:24, Bruce Evans wrote: > Just back out the part that clobbered this: > > RCS file: /home/ncvs/src/sys/nfs/nfs.h,v > Working file: nfs.h > head: 1.40 > ... > ---------------------------- > revision 1.33 > date: 1998/02/01 21:23:29; author: bde; state: Exp; lines: +15 -15 > Moved declaration of `union nethostadr' outside of the KERNEL section, > to give pollution compatible with . At least mount_nfs.c > previously had to #define KERNEL before including to get > this pollution, but this gave other pollution. > > Moved comment about NFSINT_SIGMASK to immediately before the code that > it applies to. > ---------------------------- > > Bruce -----BEGIN PGP SIGNATURE----- Version: 2.6.2 iQCVAwUBNXJETjeRhT8JRySpAQFzvgP/UXtSluOw+crdO3FLiQtpwwXEmQ9mJ2si CIALrmTFCWSx/fxMl0+ZffD5NDltnbRW9kE/wOR/+INeFj0QmerwZO1KiYrfGxJC 7TgiPKQx0ldg4g4z4Cqb5YkWOZf98oi0TWmTzlv1uKH0Jp0Bak9OjgjJOXMDUWgm b6hPagix6i0= =xcLV -----END PGP SIGNATURE----- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message