From owner-freebsd-stable@FreeBSD.ORG  Tue Nov 24 21:29:35 2009
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 209D3106566B
	for <freebsd-stable@freebsd.org>; Tue, 24 Nov 2009 21:29:35 +0000 (UTC)
	(envelope-from deischen@freebsd.org)
Received: from mail.netplex.net (mail.netplex.net [204.213.176.10])
	by mx1.freebsd.org (Postfix) with ESMTP id CEF668FC12
	for <freebsd-stable@freebsd.org>; Tue, 24 Nov 2009 21:29:34 +0000 (UTC)
Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11])
	by mail.netplex.net (8.14.3/8.14.3/NETPLEX) with ESMTP id
	nAOLTX1A015588; Tue, 24 Nov 2009 16:29:33 -0500 (EST)
X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net)
X-Greylist: Message whitelisted by DRAC access database, not delayed by
	milter-greylist-4.2.2 (mail.netplex.net [204.213.176.10]);
	Tue, 24 Nov 2009 16:29:33 -0500 (EST)
Date: Tue, 24 Nov 2009 16:29:33 -0500 (EST)
From: Daniel Eischen <deischen@freebsd.org>
X-X-Sender: eischen@sea.ntplx.net
To: Mark Andrews <marka@isc.org>
In-Reply-To: <200911242114.nAOLEZIN049990@drugs.dv.isc.org>
Message-ID: <Pine.GSO.4.64.0911241628060.5810@sea.ntplx.net>
References: <86aayc7z4g.fsf@zhuzha.ua1>
	<200911242114.nAOLEZIN049990@drugs.dv.isc.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: FreeBSD Stable <freebsd-stable@freebsd.org>,
	Mikolaj Golub <to.my.trociny@gmail.com>
Subject: Re: pthread.h: typo in
	#define	pthread_cleanup_push/pthread_cleanup_pop
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Daniel Eischen <deischen@freebsd.org>
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2009 21:29:35 -0000

On Wed, 25 Nov 2009, Mark Andrews wrote:

>
> Report it using "send-pr".  That way the problem will make its way into the
> bug tracking system.
>
> In message <86aayc7z4g.fsf@zhuzha.ua1>, Mikolaj Golub writes:
>> Hi,
>>
>> I have problems with compiling our application under 8.0.
>>
>> It fails due to these definitions in pthread.h that look like a typo or
>> incorrectly applied patch:

Did someone already reply to this?

I think the problem is in your application.  You cannot
have push and pop at different nesting levels.  The
start brace in the push is ended by the end brace in
pop on purpose.  It is to enforce nesting levels.

>>
>>     170 #define         pthread_cleanup_push(cleanup_routine, cleanup_arg)
>>        \
>>     171                 {
>>        \
>>     172                         struct _pthread_cleanup_info __cleanup_info__;
>>        \
>>     173                         __pthread_cleanup_push_imp(cleanup_routine, clean
>> up_arg,\
>>     174                                 &__cleanup_info__);
>>        \
>>     175                         {
>>     176
>>     177 #define         pthread_cleanup_pop(execute)
>>        \
>>     178                         }
>>        \
>>     179                         __pthread_cleanup_pop_imp(execute);
>>        \
>>     180                 }

-- 
DE