From owner-svn-ports-all@FreeBSD.ORG  Wed Apr  1 11:41:28 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 78A9F67B; Wed,  1 Apr 2015 11:41:28 +0000 (UTC)
Date: Wed, 1 Apr 2015 11:41:28 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Ryan Steinmetz <zi@FreeBSD.org>
Subject: Re: svn commit: r382905 - in head/sysutils: qjail qjail2
Message-ID: <20150401114128.GB82458@FreeBSD.org>
References: <201504011135.t31BZqWp028637@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201504011135.t31BZqWp028637@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Apr 2015 11:41:28 -0000

On Wed, Apr 01, 2015 at 11:35:52AM +0000, Ryan Steinmetz wrote:
> New Revision: 382905
> URL: https://svnweb.freebsd.org/changeset/ports/382905
> 
> [...]
>  	@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
> -	@(cd ${WRKSRC}/examples/ \
> +	(cd ${WRKSRC}/examples/ \
>  	    && ${COPYTREE_SHARE} \* ${STAGEDIR}${EXAMPLESDIR})

Using dot (.) instead of \* is shorter, more readable, and less error-prone
(no need to think about escaping).  That's why it is recommended by the PHB.
Since you've touched that command, you might have considered fixing this as
well.

>  	@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
> -	@(cd ${WRKSRC}/examples/			\
> +	(cd ${WRKSRC}/examples/			\
>  	&& ${COPYTREE_SHARE} \* ${STAGEDIR}${EXAMPLESDIR})

Ditto.  Also, notice bogus indentation of the backslash.

./danfe