From owner-svn-src-all@FreeBSD.ORG Fri Feb 25 22:34:20 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23171106566B; Fri, 25 Feb 2011 22:34:20 +0000 (UTC) (envelope-from dchagin@dchagin.static.corbina.ru) Received: from contrabass.post.ru (contrabass.post.ru [85.21.78.5]) by mx1.freebsd.org (Postfix) with ESMTP id C0A218FC0A; Fri, 25 Feb 2011 22:34:19 +0000 (UTC) Received: from corbina.ru (mail.post.ru [195.14.50.16]) by contrabass.post.ru (Postfix) with ESMTP id 27163CAE97; Sat, 26 Feb 2011 01:34:18 +0300 (MSK) X-Virus-Scanned: by cgpav Uf39PSi9pFi9oFi9 Received: from [10.208.17.3] (HELO dchagin.static.corbina.ru) by corbina.ru (CommuniGate Pro SMTP 5.1.14) with ESMTPS id 303866243; Sat, 26 Feb 2011 01:34:17 +0300 Received: from dchagin.static.corbina.ru (localhost [127.0.0.1]) by dchagin.static.corbina.ru (8.14.4/8.14.4) with ESMTP id p1PMYHRZ007911; Sat, 26 Feb 2011 01:34:17 +0300 (MSK) (envelope-from dchagin@dchagin.static.corbina.ru) Received: (from dchagin@localhost) by dchagin.static.corbina.ru (8.14.4/8.14.4/Submit) id p1PMYCiS007910; Sat, 26 Feb 2011 01:34:12 +0300 (MSK) (envelope-from dchagin) Date: Sat, 26 Feb 2011 01:34:12 +0300 From: Chagin Dmitry To: John Baldwin Message-ID: <20110225223412.GA7884@dchagin.static.corbina.ru> References: <201102252205.p1PM5Xlr013873@svn.freebsd.org> <201102251721.28461.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline In-Reply-To: <201102251721.28461.jhb@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219042 - in head/sys: kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2011 22:34:20 -0000 --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 25, 2011 at 05:21:28PM -0500, John Baldwin wrote: > On Friday, February 25, 2011 5:05:33 pm Dmitry Chagin wrote: > > Author: dchagin > > Date: Fri Feb 25 22:05:33 2011 > > New Revision: 219042 > > URL: http://svn.freebsd.org/changeset/base/219042 > >=20 > > Log: > > Introduce preliminary support of the show description of the ABI of > > traced process by adding two new events which records value of process > > sv_flags to the trace file at process creation/execing/exiting time. > > =20 > > MFC after: 1 Month. >=20 > Hmm, I don't find ktrace_submitrequest_ne() an intuitive name (took a bit > to figure out 'not-entered', and it doesn't map well between getrequest() > (where it means 'already-entered') and submitrequest ('don't exit')). >=20 > I would rather only have submitrequest() and getrequest() and push the > ktrace_enter() and ktrace_exit() into all the callers. >=20 thnx for the reply, I thought about it. --=20 Have fun! chd --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iEYEARECAAYFAk1oLmMACgkQ0t2Tb3OO/O19zwCfTA5pVrpGc8jW2MvajwvDp/TV kXAAnAj4OIESnq8tOnAuiKTlo5otUvVQ =bx96 -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--