From owner-freebsd-current Sun May 5 6:53:40 2002 Delivered-To: freebsd-current@freebsd.org Received: from relay1.macomnet.ru (relay1.macomnet.ru [195.128.64.10]) by hub.freebsd.org (Postfix) with ESMTP id D5B7D37B40D; Sun, 5 May 2002 06:53:27 -0700 (PDT) Received: from news1.macomnet.ru (news1.macomnet.ru [195.128.64.14]) by relay1.macomnet.ru (8.11.6/8.11.6) with ESMTP id g45DrON11533075; Sun, 5 May 2002 17:53:24 +0400 (MSD) Date: Sun, 5 May 2002 17:53:24 +0400 (MSD) From: Maxim Konovalov To: Szilveszter Adam Cc: fenner@FreeBSD.ORG, , Subject: Re: savecore.c broken now, breaks world In-Reply-To: <20020505131747.GA534@fonix.adamsfamily.xx> Message-ID: <20020505175219.W37175-100000@news1.macomnet.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 15:17+0200, May 5, 2002, Szilveszter Adam wrote: > Hello, > > src/sbin/savecore.c has been broken today, with the commit of rev 1.59 > by Bill Fenner. > > It appears that a new magic value, KERNELDUMPMAGIC_CLEARED, has been > introduced but its value never #define-d in (probably) > src/sys/sys/kerneldump.h. This way, the program does not compile. > > There is only so much one can deduce from the code, it is the author who > should know what was intended here. > > This breaks the world. This patch solves the problem: Index: sys_sys/kerneldump.h =================================================================== RCS file: /home/ncvs/src/sys/sys/kerneldump.h,v retrieving revision 1.3 diff -u -r1.3 kerneldump.h --- sys_sys/kerneldump.h 3 Apr 2002 07:24:10 -0000 1.3 +++ sys_sys/kerneldump.h 5 May 2002 13:49:04 -0000 @@ -60,6 +60,7 @@ struct kerneldumpheader { char magic[20]; #define KERNELDUMPMAGIC "FreeBSD Kernel Dump" +#define KERNELDUMPMAGIC_CLEARED "FreeBSD Cleard Dump" char architecture[12]; uint32_t version; #define KERNELDUMPVERSION 1 %%% -- Maxim Konovalov, MAcomnet, Internet Dept., system engineer phone: +7 (095) 796-9079, mailto:maxim@macomnet.ru To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message