From nobody Fri May 5 15:07:54 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QCYw06p0sz49RRY; Fri, 5 May 2023 15:08:00 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QCYw01yHGz3s1j; Fri, 5 May 2023 15:08:00 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1683299276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pKq8ij9JHz2/og2f3TciNCZePfyX5mb2+jCLzq6mKqE=; b=q1iVly2QlNeac67kGHydiUsAghmX7weQuktOdBaxwOdDsl2OEk5+5t0KBINsaIhGXwhiKI BB1o7V4J6v+rfV7sWaE4UvkHm23at94XMMtkTFcyGZJtnld/wcdJWk/FjbrLyOhJNNED46 1Xx1c6hEY1Hj52gV0MZNCvSW9BK1LuU= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id dba7125c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 5 May 2023 15:07:55 +0000 (UTC) Date: Fri, 5 May 2023 17:07:54 +0200 From: Emmanuel Vadot To: Kyle Evans Cc: ihor@antonovs.family, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8935a3993219 - main - daemon: use kqueue for all events Message-Id: <20230505170754.01f9e99fbc90e7afede80ae9@bidouilliste.com> In-Reply-To: References: <202304140513.33E5DsXL019547@gitrepo.freebsd.org> <20230505105935.c2e6df2864b7a9ab6c6fef81@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4QCYw01yHGz3s1j X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Fri, 5 May 2023 10:00:04 -0500 Kyle Evans wrote: > On Fri, May 5, 2023 at 3:59?AM Emmanuel Vadot wro= te: > > > > > > Hello, > > > > On Fri, 14 Apr 2023 05:13:54 GMT > > Kyle Evans wrote: > > > > > The branch main has been updated by kevans: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D8935a3993219be76c7ea03= e9ad4509657d08af6c > > > > > > commit 8935a3993219be76c7ea03e9ad4509657d08af6c > > > Author: Ihor Antonov > > > AuthorDate: 2023-04-14 05:10:29 +0000 > > > Commit: Kyle Evans > > > CommitDate: 2023-04-14 05:12:21 +0000 > > > > > > daemon: use kqueue for all events > > > > > > Refactor daemon to use kqueue/kevent instead of signals. > > > > > > This changes allows to simplify the code in several ways: > > > - the execution flow is now linear, no async events. > > > - several variables became redundant and got removed. > > > - all event handling is now concentrated inside of the event loop= , which > > > makes code reading and comprehension easier. > > > - new kqueuex(2) call is used for CLOEXEC, but maintained closing= the > > > kq fd prior to execve() to ease later MFC > > > > > > No UX/API changes are intended. > > > > > > Reviewed by: kevans > > > Pull Request: https://github.com/freebsd/freebsd-src/pull/701 > > > > This break sysutils/seatd when we resume and leaves the console is a > > really sad state (impossible to use, keystroke don't match). > > Don't really know how to properly debug but : > > > > 1/ Reverting the commit make seatd not exiting on resume (and so sway > > doesn't exit). > > 2/ If I start seatd without daemon it works > > 3/ If I manually start saetd with daemon in tmux with > > "daemon -s debug -T seatd -p /var/run/seatd.pid /usr/local/bin/seatd > > -g video" (so same thing as the rc script) I see > > "daemon: kevent wait: Interrupted system call" printed when I get back > > network. > > > > Feel free to ask me any test you want to debug further ;) > > >=20 > Can you check if this is sufficient? > https://people.freebsd.org/~kevans/daemon-kq.diff >=20 > We shouldn't bail out if were simply interrupted, presumably we just > want to resume waiting for an event. >=20 > Thanks, >=20 > Kyle Evans Seems to work fine, thanks ! --=20 Emmanuel Vadot