Date: Mon, 19 Jun 2006 16:14:48 +0200 From: Andre Oppermann <andre@freebsd.org> To: Blue <Susan.Lan@zyxel.com.tw> Cc: freebsd-net@freebsd.org Subject: Re: [FreeBSD-6.1RELEASE] tcp in TIME_WAIT state Message-ID: <4496B158.3090907@freebsd.org> In-Reply-To: <4496721C.5030008@zyxel.com.tw> References: <4496721C.5030008@zyxel.com.tw>
next in thread | previous in thread | raw e-mail | index | archive | help
Blue wrote: > Hi, all: > > In function tcp_timewait(), which will be called when receiving a > segment as current TCP state at TIME_WAIT. However, in the body of the > function definition, it simply goes to "drop" before generating RST or > RST/ACK towards the unicast source. Is the behavior correct because the > followed codes (from line 2228 to line 3261) would never be reached! Yes, this code was never used. After the 'goto drop;' there used to be a 'reset:' label. However it was never used and got lost in rev. 1.254 because of compiler warnings. The code is related to the comment earlier in the function: "NOTE: for FIN_WAIT_2 (to be added later), must validate sequence number before accepting RST". I agree that is very confusing and I shall put an appropriate comment next to it. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4496B158.3090907>