Date: Thu, 09 Apr 2015 11:51:09 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r383191 - head/Mk Message-ID: <5526ADFD.2020500@FreeBSD.org> In-Reply-To: <20150409164926.GC45809@hades.panopticon> References: <201504040535.t345ZJ9M028396@svn.freebsd.org> <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon> <5525D48E.5090305@FreeBSD.org> <20150409110221.GB45809@hades.panopticon> <55269785.7030307@FreeBSD.org> <20150409153856.GA31951@FreeBSD.org> <55269FE4.2030208@FreeBSD.org> <20150409164926.GC45809@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TCR9j4xv8xS7rru1Su2fng3Pv2eclace9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/9/2015 11:49 AM, Dmitry Marakasov wrote: > * Bryan Drewery (bdrewery@FreeBSD.org) wrote: >=20 >>>> *That* made sense. Frankly I think all dev warnings should be disabl= ed >>>> in that case though. Setting up ports like this may work but it is n= ot a >>>> good way to test a port before committing or submitting it. Many por= ts >>>> and their framework files reference "CURDIR/../..". In r327743 I >>>> modified www/linux-seamonkey to use PORTSDIR here and I believe I br= oke >>>> the workflow for the maintainers testing. The ports tree really need= s to >>>> be tested as a whole. This is why portshaker exists, so you can brin= g in >>>> your partial tree into a full tree. Unionfs in theory is for this to= o. >>> >>> Bryan, I'm on Dmitry's side here. Building some "foo" port from outs= ide >>> /usr/ports (or a properly checked out tree) is very handy feature, an= d it >>> had worked for many years; and while perhaps never officially adverti= sed, >>> silently breaking it is a huge POLA violation for power users. I wou= ld >>> really appreciate if we can have this behavior back. >> >> I am in favor of fixing it. I just think all the tests should be >> disabled. It won't make sense to have some tests enabled and some not.= >> It's no good if the port passes in your out-of-tree build for 1/2 the >> tests and then you just straight commit and find that it fails all of >> the other tests. >=20 > I don't see the point. Why disable all checks while they can detect > problems early (while the port is still out-of-tree), instead of > making developer experience inconsistent behavior without explanation? > In either case, we need something like >=20 > WARNING+=3D"the port doesn't reside in the ports tree directory structu= re, not all sanity checks could be performed" >=20 > but I'd really prefer only tests which are ctually affected by this to = be > disabled. >=20 This is what my proposed patch does! --=20 Regards, Bryan Drewery --TCR9j4xv8xS7rru1Su2fng3Pv2eclace9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVJq39AAoJEDXXcbtuRpfP3f0H/RDNh0t6m/wJlNEBljk264ll URrLuIknNmpxN6TrAV85YCPgvND33yco2ccBnvKDfLQbkFX4zjfvusIrPW6vf41K Sa16h+Z23Vd7N5B2rEiwFg2RWNDv9s9CNZNZofNrrt/Xh9b6jMNv0ipPOY6tCyjZ XW5B/9488y6Y9tfUNIi4MuDemPgSKBArNN1OBkW1VUQn7MNNaB2RNE+v/aVKfWo5 TavnrAfIQy3Un3h/tsh2DppZQq0egtYs4Duap3peoyiTA7sn3m87in965pJcTlUh +xJkYuYLdlzxaomO2EkCjzmALZ+CVGjMe4SjgkDylU7e0vbOPMVpWuYwbMxLT/A= =UFIv -----END PGP SIGNATURE----- --TCR9j4xv8xS7rru1Su2fng3Pv2eclace9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5526ADFD.2020500>