From owner-svn-src-all@freebsd.org Sat Jul 23 01:24:43 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 628EDBA000F; Sat, 23 Jul 2016 01:24:43 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 395511472; Sat, 23 Jul 2016 01:24:43 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id E7D7314F5; Sat, 23 Jul 2016 01:24:42 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 926C22363A; Sat, 23 Jul 2016 01:24:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id WGdVMV_FUfS8; Sat, 23 Jul 2016 01:24:39 +0000 (UTC) Subject: Re: svn commit: r303188 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 8EC5123634 To: Bruce Evans , Ngie Cooper References: <201607221500.u6MF0c3S037470@repo.freebsd.org> <1980140.IgFQbb5iVz@ralph.baldwin.cx> <20160723073428.K1265@besplex.bde.org> <20160723100100.K1644@besplex.bde.org> Cc: John Baldwin , Ruslan Bukin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Fri, 22 Jul 2016 18:24:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160723100100.K1644@besplex.bde.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hWg8axHEw5p9tjwWoIrq85ucH17TTiRqs" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2016 01:24:43 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hWg8axHEw5p9tjwWoIrq85ucH17TTiRqs Content-Type: multipart/mixed; boundary="3KrF1axrX0xGX63RMlHQPaAmMCHPOLCLf" From: Bryan Drewery To: Bruce Evans , Ngie Cooper Cc: John Baldwin , Ruslan Bukin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: Subject: Re: svn commit: r303188 - head/share/mk References: <201607221500.u6MF0c3S037470@repo.freebsd.org> <1980140.IgFQbb5iVz@ralph.baldwin.cx> <20160723073428.K1265@besplex.bde.org> <20160723100100.K1644@besplex.bde.org> In-Reply-To: <20160723100100.K1644@besplex.bde.org> --3KrF1axrX0xGX63RMlHQPaAmMCHPOLCLf Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 7/22/2016 5:25 PM, Bruce Evans wrote: > On Fri, 22 Jul 2016, Ngie Cooper wrote: >=20 >> On Fri, Jul 22, 2016 at 2:57 PM, Bruce Evans >> wrote: >> ... >>>>> +# GCC 6.1.0 >>>>> +.if ${COMPILER_TYPE} =3D=3D "gcc" && ${COMPILER_VERSION} >=3D 6010= 0 >>>>> +CWARNFLAGS+=3D -Wno-error=3Dunused-const-variable=3D >>>>> -Wno-error=3Dnonnull-compare -Wno-error=3Dshift-negative-value >>>>> -Wno-error=3Dmisleading-indentation -Wno-error=3Dtautological-compa= re >>>>> +.endif >>>> >>>> >>>> Extra trailing =3D in the first one as well? >>> >>> I don't see one. I see only unreadably long lines containing unreada= bly >>> unordered flags. Perhaps your mail client mangled the line splitting= , >>> but the above quite displays OK in mutt and vi here (except mutt make= s >>> the line wrapping especially ugly by highlighting it). >> >> Look for "-Wno-error=3Dunused-const-variable=3D". >=20 > It is not trailing :-). It is only trailing in the above quote and > apparently in the mail as seen by jhb because some mail programs mangle= > the formatting worse than others. In the above quote as seen by me > in EDITOR=3Dvi, the long line is split and each part is quoted. But in= > the previous quote, the line wasn't split. Since it was unreadable > by me, I used the editor search function to check if it had a trailing > '=3D' using a regexp, and none was found. It's not a mail issue. It is in the actual file. See https://svnweb.freebsd.org/base/head/share/mk/bsd.sys.mk?r1=3D303188&r2=3D= 303187&pathrev=3D303188 and https://svnweb.freebsd.org/base/head/share/mk/bsd.sys.mk?revision=3D30318= 8&view=3Dmarkup&pathrev=3D303188#l119 Specifically "-Wno-error=3Dunused-const-variable=3D", the first value. --=20 Regards, Bryan Drewery --3KrF1axrX0xGX63RMlHQPaAmMCHPOLCLf-- --hWg8axHEw5p9tjwWoIrq85ucH17TTiRqs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXksdZAAoJEDXXcbtuRpfPnYkIANN/gpwkavD5NUHntyP7F1DW e9r3K8caZkOulpN0MYVdlHe6NP1K5ktLS/JDrM/4+iByNAuBIYI9BxCfbtGP8UVA Qm1a0Zj+VGtK0AVm1P4fAz6i0ZZG5FNdeOf4vDDMNH+/We9y79kLlIhDHLWRM9T8 5fKQbIiIRDQOIbV1ZJ9NNdImbG931hSkA/dFQSDpUckNykIbK9pLGdP/NyHeGJ5Y J6y/dJThxEMZjcXuODL/tFoxUmQ8t4fFb/L+baZ1cSu1Bb4jL8R3jWaGKvo+l4EM uQkM4fGZ+hg5YKy8tfzomIBooo+PwLXnhgq6EiGmVKYmIoVnHhhgFTU31j0gE9o= =UudZ -----END PGP SIGNATURE----- --hWg8axHEw5p9tjwWoIrq85ucH17TTiRqs--