From owner-cvs-src-old@FreeBSD.ORG Wed Dec 2 03:08:48 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37A06106570A for ; Wed, 2 Dec 2009 03:08:48 +0000 (UTC) (envelope-from wollman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 232E18FC1D for ; Wed, 2 Dec 2009 03:08:48 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id nB238mnx058258 for ; Wed, 2 Dec 2009 03:08:48 GMT (envelope-from wollman@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id nB238mGl058257 for cvs-src-old@freebsd.org; Wed, 2 Dec 2009 03:08:48 GMT (envelope-from wollman@repoman.freebsd.org) Message-Id: <200912020308.nB238mGl058257@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to wollman@repoman.freebsd.org using -f From: Garrett Wollman Date: Wed, 2 Dec 2009 03:08:29 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_7 Subject: cvs commit: src/lib/libc/gen getcap.c getusershell.c wordexp.c src/lib/libc/rpc clnt_raw.c getnetconfig.c key_call.c src/lib/libc/stdio fgetws.c fvwrite.c vfwprintf.c src/lib/libc/yp yplib.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2009 03:08:48 -0000 wollman 2009-12-02 03:08:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/gen getcap.c getusershell.c wordexp.c lib/libc/rpc clnt_raw.c getnetconfig.c key_call.c lib/libc/stdio fgetws.c fvwrite.c vfwprintf.c lib/libc/yp yplib.c Log: SVN rev 200017 on 2009-12-02 03:08:29Z by wollman MFC revs 199781,199782,199784,199786: Eliminate dead stores. In __mbsconv(), if prec was zero, nconv could have been used uninitialized. Initialize it to a safe value so that there's no chance of returning an error if stack garbage happens to be equal to (size_t)-1 or (size_t)-2. In clnt_raw_create(), avoid minor race condition initializing the file-scope variable clntraw_private. Mark head rev 199785 as merged; 7-STABLE's version of svc_raw_reply() doesn't have the same bug (or even look all that similar). Found by: Clang static analyzer Revision Changes Path 1.20.2.2 +2 -3 src/lib/libc/gen/getcap.c 1.10.2.1 +1 -1 src/lib/libc/gen/getusershell.c 1.6.18.1 +1 -1 src/lib/libc/gen/wordexp.c 1.20.2.1 +7 -4 src/lib/libc/rpc/clnt_raw.c 1.14.2.2 +2 -2 src/lib/libc/rpc/getnetconfig.c 1.16.2.1 +1 -1 src/lib/libc/rpc/key_call.c 1.6.10.1 +1 -1 src/lib/libc/stdio/fgetws.c 1.18.2.1 +1 -1 src/lib/libc/stdio/fvwrite.c 1.27.2.3 +1 -1 src/lib/libc/stdio/vfwprintf.c 1.51.2.1 +1 -1 src/lib/libc/yp/yplib.c