From nobody Sun Jan 23 18:24:36 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5BC771959A5F for ; Sun, 23 Jan 2022 18:24:49 +0000 (UTC) (envelope-from wma@semihalf.com) Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JhhNd0N1Cz4jWk for ; Sun, 23 Jan 2022 18:24:48 +0000 (UTC) (envelope-from wma@semihalf.com) Received: by mail-yb1-xb35.google.com with SMTP id r65so40591712ybc.11 for ; Sun, 23 Jan 2022 10:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=udrd0ebPgJzrDf3UED908D/oY+BcBomUJiAGmNdd29Q=; b=EUuevTdQTZNbMjwEzCiWqXjn848AOQw2HWisP3FVhomrA9uUGy4pHdcoAxYvlnkAvg TmY3/efKCJ9+rz7OAVGuxIegiBoh19SqmSqTRs9cubVArZlcSL+4TOu/DJIkVecDd3ND PEpFXZsh1jUU+p/oD3xJISOrQ+G0vFPHgpTZA/fnP2ugQEI2cRZrwr06HS+bn8amf8YM kiMOgKoevtKeMWKojUwZ8+5tFMAIKED7Ve+dG1QnfOuqg6cGRnx4lFqwxQaxGTatFVgz k3GOLsNpNqc6C/UcbbluIe0R5cS7tN/rWnw9XSaBkxB+U3Mk4t1xKaVDbat6PWeH6cA3 gw7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=udrd0ebPgJzrDf3UED908D/oY+BcBomUJiAGmNdd29Q=; b=cloGE/DKLiSMfQAPjpqt1qYL/yptps4XBvhtN8rgTIaKj3tyTehQ7Vmig7PjsdAOHm nOn94Cd83LpR7+vej1u92EjLU/EX9P0mmk+GWbcA2UWBjvda+4C785Br91gnjkQm4Iag +kjfH77LaCKV7Asvu0CcVcUvP+hz2HelHUpk5wgGZjkErXWYduGnoi+wuwNur6tOMwyJ Re9vLEjHWQqokFYsjEuxkDeHusXcvVDlrn4qJBmiiRXZT7C0ybtfjkVRX83Y420zi3Xp fOVDafuIJkCXmVKKYnQxbq/iTg1QABlOKm/RJmCtcpiUSdwGTCnq4JlzN5HOkDeJz+Zk LLMw== X-Gm-Message-State: AOAM533PkKbNkUo49HdHLWYDlK1/Vm2QoeRlZSVgkyQ/beUed89d7j3c J6vISUxMSLgl9xZlpSIZbAEyvKch1yzGtCieLL1bPA== X-Google-Smtp-Source: ABdhPJwOd3hH5P3QTy7teQIpJrmpp6Y763/jd+af10FsJa+XF1OEMloel4G85BXIEw0yKDtOPaBacCLzVRuekRPQRbw= X-Received: by 2002:a25:2786:: with SMTP id n128mr18901460ybn.491.1642962288448; Sun, 23 Jan 2022 10:24:48 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202201210519.20L5J1mJ029323@gitrepo.freebsd.org> <7A991003-0F24-4C8C-81FD-84F39FC78D8A@FreeBSD.org> In-Reply-To: From: Wojciech Macek Date: Sun, 23 Jan 2022 19:24:36 +0100 Message-ID: Subject: Re: git: 9ce46cbc95d7 - main - ip_mroute: move ip_mrouter_done outside lock To: Gleb Smirnoff Cc: Kristof Provost , Wojciech Macek , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000095288505d643f733" X-Rspamd-Queue-Id: 4JhhNd0N1Cz4jWk X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --00000000000095288505d643f733 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This is an orginal fix. The issue was visible due to race between ip input/output and mrouter uninit. https://reviews.freebsd.org/D29946 niedz., 23 sty 2022, 17:41 u=C5=BCytkownik Gleb Smirnoff napisa=C5=82: > On Sat, Jan 22, 2022 at 08:50:54AM +0100, Wojciech Macek wrote: > W> I will prepare a fix later today. Basically, the whole "if" condition > must > W> be inside rwlock block to avoid race during module unload. > W> Maybe adding else and rwunlock in rip_detach will suffice.... I need t= o > try > W> it out. > > May I ask you to post a review and add me as reviewer? Please also includ= e > a description of the problem we are fighting with. At least, a short > version > of it, for example "fix race between module unload and packet received". > > -- > Gleb Smirnoff > --00000000000095288505d643f733 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This is an orginal fix. The issue was visible due to race= between ip input/output and mrouter uninit.=C2=A0

niedz., 23 sty 2022, 17:41 u=C5=BCytkownik Gleb Smirnoff <<= a href=3D"mailto:glebius@freebsd.org">glebius@freebsd.org> napisa=C5= =82:
On Sat, Jan 22, 2022 at 08:50:= 54AM +0100, Wojciech Macek wrote:
W> I will prepare a fix later today. Basically, the whole "if"= condition must
W> be inside rwlock block to avoid race during module unload.
W> Maybe adding else and rwunlock in rip_detach will suffice.... I need = to try
W> it out.

May I ask you to post a review and add me as reviewer? Please also include<= br> a description of the problem we are fighting with. At least, a short versio= n
of it, for example "fix race between module unload and packet received= ".

--
Gleb Smirnoff
--00000000000095288505d643f733--