From owner-cvs-all@FreeBSD.ORG  Sat Sep 24 22:47:03 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F12C116A41F;
	Sat, 24 Sep 2005 22:47:02 +0000 (GMT) (envelope-from nate@root.org)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A39FE43D48;
	Sat, 24 Sep 2005 22:47:02 +0000 (GMT) (envelope-from nate@root.org)
Received: from [10.0.0.250] (ppp-71-139-46-176.dsl.snfc21.pacbell.net
	[71.139.46.176])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8OMl6o5005949
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Sat, 24 Sep 2005 15:47:06 -0700
Message-ID: <4335D760.9080007@root.org>
Date: Sat, 24 Sep 2005 15:46:56 -0700
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Poul-Henning Kamp <phk@FreeBSD.org>
References: <20050924193119.F1A8A16A448@hub.freebsd.org>
In-Reply-To: <20050924193119.F1A8A16A448@hub.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys bus.h rman.h types.h src/sys/kern   
 subr_bus.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Sep 2005 22:47:03 -0000

Poul-Henning Kamp wrote:
> --- src/sys/sys/bus.h:1.71	Sun Sep 18 01:32:09 2005
> +++ src/sys/sys/bus.h	Sat Sep 24 19:31:10 2005
> @@ -85,11 +85,6 @@
>      const char *__type, const char *__data);
>  void devctl_queue_data(char *__data);
>  
> -/*
> - * Forward declarations
> - */
> -typedef struct device		*device_t;
> -
>  /**
>   * @brief A device driver (included mainly for compatibility with
>   * FreeBSD 4.x).

> diff -u src/sys/sys/types.h:1.92 src/sys/sys/types.h:1.93
> --- src/sys/sys/types.h:1.92	Tue May 31 15:18:17 2005
> +++ src/sys/sys/types.h	Sat Sep 24 19:31:10 2005
> @@ -285,6 +285,7 @@
>  typedef	__uintfptr_t	uintfptr_t;
>  typedef	__uint64_t	uoff_t;
>  typedef	struct vm_page	*vm_page_t;
> +typedef struct device	*device_t;
>  
>  #define offsetof(type, field) __offsetof(type, field)

I don't think our device_t definition belongs in sys/types.h.  It is 
opaque for a reason.

-- 
Nate