From owner-cvs-all Mon Aug 2 22: 9:55 1999 Delivered-To: cvs-all@freebsd.org Received: from norn.ca.eu.org (cr965240-b.abtsfd1.bc.wave.home.com [24.113.19.137]) by hub.freebsd.org (Postfix) with ESMTP id A40701522E; Mon, 2 Aug 1999 22:09:49 -0700 (PDT) (envelope-from cpiazza@norn.ca.eu.org) Received: by norn.ca.eu.org (Postfix, from userid 1002) id 3184836; Mon, 2 Aug 1999 22:09:22 -0700 (PDT) Date: Mon, 2 Aug 1999 22:09:22 -0700 From: Chris Piazza To: Gary Jennejohn Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: ports/devel/codecrusader - Imported sources Message-ID: <19990802220922.A27630@norn.ca.eu.org> References: <199908022318.QAA87445@freefall.freebsd.org> <199908030409.GAA87587@peedub.muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.6i In-Reply-To: <199908030409.GAA87587@peedub.muc.de>; from Gary Jennejohn on Tue, Aug 03, 1999 at 06:09:20AM +0200 X-Operating-System: FreeBSD 4.0-CURRENT Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Tue, Aug 03, 1999 at 06:09:20AM +0200, Gary Jennejohn wrote: > > this port still has problems. If you do ``CODEMEDIC=no make all'' > then patch-ab fails to apply because it needs the codemedic stuff. > The PLIST is also incorrect in this case since it assumes that > bin/medic is always installed. OK, but missing files from the PLIST isn't a big deal anyway, it'll just emit a warning. We really want PLIST to have everything for package building. > > portlint also still emits 2 warnings, but that's not so bad. However, > it's trivial to fix the Makefile so that no errors or warnings are > emitted (as per my previous mail). All warnings don't have to be removed. > > the first problem _is_ bad, however. Doesn't look like you tested this > too well before committing it. Oh bah. I'm sorry I forgot to compile every port there is with every single option possible. I'm most interested that it works for the major case which is package building and default compiles. Feel free to send patches. -Chris -- cpiazza@home.net cpiazza@FreeBSD.org "It's better to be quotable than to be honest." --Tom Stoppard To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message