From owner-freebsd-current@FreeBSD.ORG Mon Oct 31 20:43:49 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 529D916A41F; Mon, 31 Oct 2005 20:43:49 +0000 (GMT) (envelope-from mike@sentex.net) Received: from smarthost1.sentex.ca (smarthost1.sentex.ca [64.7.153.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D90243D62; Mon, 31 Oct 2005 20:43:43 +0000 (GMT) (envelope-from mike@sentex.net) Received: from pumice3.sentex.ca (pumice3.sentex.ca [64.7.153.26]) by smarthost1.sentex.ca (8.13.4/8.13.4) with ESMTP id j9VKheCl086764; Mon, 31 Oct 2005 15:43:40 -0500 (EST) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (pyroxene.sentex.ca [199.212.134.18]) by pumice3.sentex.ca (8.13.4/8.13.4) with ESMTP id j9VKheL9090513; Mon, 31 Oct 2005 15:43:40 -0500 (EST) (envelope-from mike@sentex.net) Received: from simian.sentex.net (simeon.sentex.ca [192.168.43.27]) by lava.sentex.ca (8.13.3/8.13.3) with ESMTP id j9VKhdvW071920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Oct 2005 15:43:39 -0500 (EST) (envelope-from mike@sentex.net) Message-Id: <6.2.3.4.0.20051031154030.04ac4310@64.7.153.2> X-Mailer: QUALCOMM Windows Eudora Version 6.2.3.4 Date: Mon, 31 Oct 2005 15:42:53 -0500 To: John Baldwin , current@freebsd.org From: Mike Tancsa In-Reply-To: <200510281548.34796.jhb@freebsd.org> References: <200510281548.34796.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-Virus-Scanned: by amavisd-new X-Scanned-By: MIMEDefang 2.51 on 64.7.153.18 X-Scanned-By: MIMEDefang 2.53 on 64.7.153.26 Cc: Subject: Re: [PATCH] Locking fixes for vr(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2005 20:43:49 -0000 At 02:48 PM 28/10/2005, John Baldwin wrote: >- Fix vr(4) to use callout_*() so that its callout runs without Giant. >- Fix locking in detach. > >Please test, thanks! > >http://www.FreeBSD.org/~jhb/patches/vr_locking.patch Its been running fine over the weekend. I have a DSL link over it and didnt see any dropped connections or odd issues. This is on a mini-itx board with built in rl and vr NICs vr0: port 0xd800-0xd8ff mem 0xfc003000-0xfc0030ff irq 10 at device 18.0 on pci0 miibus1: on vr0 ukphy0: on miibus1 ukphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto vr0: Ethernet address: 00:03:1d:02:0a:ee. I patched against 6.0.RC1 from Friday. ---Mike