From owner-freebsd-net@FreeBSD.ORG Tue Mar 4 12:07:35 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5FB2810656BE for ; Tue, 4 Mar 2008 12:07:35 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.188]) by mx1.freebsd.org (Postfix) with ESMTP id E7F278FC1D for ; Tue, 4 Mar 2008 12:07:34 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so544087nfb.33 for ; Tue, 04 Mar 2008 04:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:sender; bh=oLp4LnJKhqEft6JqLo+QlA+BQ47ZcAzb1thvSqUH6S0=; b=XxjAxFOkuF1LfPLMvbpFeL/2KwA/LLMVYZG+UI9RBygAiJuKNNkWl43TbCMwfl0hMySVM/r4mn+dyc0RDee6qu7xWiUEwefZ4scqxxP21kQ/0lLabbUSuI1xy+aXKb5UGQ3R3qGuAbxFKuKRNVQMo2PRZ5ckLQG3wE+14NTgbA0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:sender; b=G1Z9CsZShPOAYvERPlb91CapEkChDYNQYUZEtvh9tp5baLMvLmsoLPRF3tGUV2+R98HAXR1BJoV1AoRcks/DSlapaaWXe+ZFZoFIJaX+E3eij/D15oAWg0KfrAbdbv10WoggVog7GQgsaUe536OS3rar5jF0ofIqEmsDTaUNgJs= Received: by 10.82.165.13 with SMTP id n13mr4441235bue.16.1204632452991; Tue, 04 Mar 2008 04:07:32 -0800 (PST) Received: from fnop.net ( [89.214.156.200]) by mx.google.com with ESMTPS id p10sm1857877gvf.8.2008.03.04.04.07.30 (version=SSLv3 cipher=OTHER); Tue, 04 Mar 2008 04:07:32 -0800 (PST) Date: Tue, 4 Mar 2008 01:36:58 +0000 From: Rui Paulo To: Mike Silbersack Message-ID: <20080304013658.GC1015@fnop.net> References: <200803030435.m234Z7As026508@venus.xmundo.net> <20080303001004.R37933@odysseus.silby.com> <200803031412.m23EC4WB031100@venus.xmundo.net> <20080303231459.X43305@odysseus.silby.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080303231459.X43305@odysseus.silby.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: Rui Paulo Cc: freebsd-net@freebsd.org Subject: Re: Ephemeral ports patch (fixed) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 12:07:35 -0000 On Mon, Mar 03, 2008 at 11:23:16PM -0600, Mike Silbersack wrote: > > > On Mon, 3 Mar 2008, Fernando Gont wrote: > >> At 04:11 a.m. 03/03/2008, Mike Silbersack wrote: >> >>>> Here's the same patch, but with the first ephemeral port changed from >>>> 1024 to 10000. >>> >>> Now that I've actually gone to try to apply the patch (so I can view the >>> two codepaths side by side, rather than in diff form), I'm finding that I >>> can't apply it. I think all the whitespace got stomped, either by your >>> mail program or my mail program. Can you please resent this as an >>> attachment? >> >> Sure. Please let me know if this one is okay. >> >> Kind regards, >> >> -- >> Fernando Gont >> e-mail: fernando@gont.com.ar || fgont@acm.org >> PGP Fingerprint: 7809 84F5 322E 45C7 F1C9 3945 96EE A9EF D076 FFF1 > > Too optimistic: > > ! #define IPPORT_EPHEMERALLAST 655535 > > Otherwise the patch looks good to me. It looked a bit strange in unified > diff format, I needed to look at it in context format. (Strange, since I > usually prefer unified.) > > Rui, were you going to get this committed? Yup, I will. Regards. -- Rui Paulo