From owner-cvs-src@FreeBSD.ORG  Tue Sep 26 15:49:13 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AB76A16A4DA;
	Tue, 26 Sep 2006 15:49:13 +0000 (UTC) (envelope-from arr@watson.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 244F443D5A;
	Tue, 26 Sep 2006 15:48:43 +0000 (GMT) (envelope-from arr@watson.org)
Received: from fledge.watson.org (localhost.watson.org [127.0.0.1])
	by fledge.watson.org (8.13.8/8.13.8) with ESMTP id k8QFmVBl038833;
	Tue, 26 Sep 2006 11:48:31 -0400 (EDT) (envelope-from arr@watson.org)
Received: from localhost (arr@localhost)
	by fledge.watson.org (8.13.8/8.13.8/Submit) with ESMTP id
	k8QFmUSl038828; Tue, 26 Sep 2006 11:48:31 -0400 (EDT)
	(envelope-from arr@watson.org)
X-Authentication-Warning: fledge.watson.org: arr owned process doing -bs
Date: Tue, 26 Sep 2006 11:48:30 -0400 (EDT)
From: "Andrew R. Reiter" <arr@watson.org>
To: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
In-Reply-To: <20060926041406.GE80527@funkthat.com>
Message-ID: <20060926114811.F46437@fledge.watson.org>
References: <200609260121.k8Q1Llo8049117@repoman.freebsd.org>
	<20060925215235.C46437@fledge.watson.org>
	<20060926041406.GE80527@funkthat.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/netinet tcp_input.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Sep 2006 15:49:13 -0000

On Mon, 25 Sep 2006, John-Mark Gurney wrote:

:Andrew R. Reiter wrote this message on Mon, Sep 25, 2006 at 21:53 -0400:
:> On Tue, 26 Sep 2006, John-Mark Gurney wrote:
:> 
:> :jmg         2006-09-26 01:21:47 UTC
:> :
:> :  FreeBSD src repository
:> :
:> :  Modified files:
:> :    sys/netinet          tcp_input.c 
:> :  Log:
:> :  fix calculating to_tsecr...  This prevents the rtt calculations from
:> :  going all wonky...
:> :  
:> :  Revision  Changes    Path
:> :  1.309     +1 -1      src/sys/netinet/tcp_input.c
:> 
:> At some point will it be safe to remove that min/max check?  
:
:Do you mean replace the else? or do you mean change it entirely?
:
:Unless someone can think of a reason why the retransmit timer should
:ever be allowed to go above 64 seconds, I'd consider replacing the
:else, but as I see it, it prevents run away code, though w/o the
:else I probably wouldn't of found this bug...
:
turn into KASSERT or something
--
arr@watson.org