From owner-svn-src-all@FreeBSD.ORG Sun Nov 18 21:59:23 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 742B4BE2; Sun, 18 Nov 2012 21:59:23 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9C78A8FC0C; Sun, 18 Nov 2012 21:59:22 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id je9so928055bkc.13 for ; Sun, 18 Nov 2012 13:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=AzTITCsqTpjKBUtN5rfe4Se04vuDeA3T6G4MMkUUdhE=; b=dtwJC1Vcz/8fb/Wv39+jOYRYqDGQh2weYpIE2J86PmNf500n0l5EJ0RfYGPoA87Afk tW4rnqKjZpu0PeXbah5MSOs+sXCfDYvYI7EujdRqW7vgrFGvKLiwR6Ci8ZIM8E5VFrX2 A304avOgk6GuWF0GccoX4bvBI9SfQVuGIEhUIVS0g/9OpVzxm1GEJOO+tfjxL/7jedKz /m6gQ/shyP9ZD/AORFoPbb6sGUK908r6iRF/mBmahMgGrpMZyCr3RU5T23uZB5/InViO 2+rvJ34OdFlpBoZqflpau7xp7LPMUVgLIJ7e8ERWyZlJOPJX2SM+DwpsVksyf5c55ZgF 8jrA== MIME-Version: 1.0 Received: by 10.204.130.140 with SMTP id t12mr2669464bks.39.1353275961450; Sun, 18 Nov 2012 13:59:21 -0800 (PST) Received: by 10.204.50.197 with HTTP; Sun, 18 Nov 2012 13:59:21 -0800 (PST) Received: by 10.204.50.197 with HTTP; Sun, 18 Nov 2012 13:59:21 -0800 (PST) In-Reply-To: References: <201211181421.qAIEL5KT042019@svn.freebsd.org> Date: Sun, 18 Nov 2012 21:59:21 +0000 Message-ID: Subject: Re: svn commit: r243228 - head/etc From: Chris Rees To: Ed Schouten Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 21:59:23 -0000 On 18 Nov 2012 20:39, "Ed Schouten" wrote: > > Hi Chris, > > 2012/11/18 Chris Rees : > > Modified: head/etc/rc.initdiskless > > ============================================================================== > > --- head/etc/rc.initdiskless Sun Nov 18 14:05:28 2012 (r243227) > > +++ head/etc/rc.initdiskless Sun Nov 18 14:21:05 2012 (r243228) > > @@ -354,7 +354,7 @@ for i in ${templates} ; do > > subdir=${j##*/} > > if [ -d $j -a ! -f $j.cpio.gz ]; then > > create_md $subdir > > - cp -Rp $j/ /$subdir > > + (cd $j && pax -rw . /$subdir) > > fi > > done > > for j in /conf/$i/*.cpio.gz ; do > > Are you sure that this bug wasn't already fixed? The original version > of the code in the bug report used the following line: > > - cp -Rp $j/* /$subdir > > The old version of the code you changed didn't have this asterisk, > meaning dotfiles would already be copied. Still, you could argue that > your version is nicer, as our behaviour of cp with the trailing slash > contradicts POSIX. > You are correct, and the second to point it out :) As you say however, pax is technically how it should be done anyway, and has the nice effect of also preserving hard links. If no-one objects I think it should stay in. This is unfortunately another example of many in rc of where something was fixed ages ago and no-one checked GNATS :( Of course, this is still my fault. Chris