From owner-svn-src-all@freebsd.org Mon Apr 23 16:07:05 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C2FEFA5882 for ; Mon, 23 Apr 2018 16:07:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C40A3809AA for ; Mon, 23 Apr 2018 16:07:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x236.google.com with SMTP id d11-v6so11213082iof.11 for ; Mon, 23 Apr 2018 09:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=oawvsSmOiJWb5tMjiSLRsp58BTv+snGWdLXEJpaaGbw=; b=C5PUylckkubi7NrhaU98CNigrGBzFpuqbqvUS7oKBeHw4EpRTHEP6hBYqqsZT1hOYn rqNV4iXqhjDiTXKXzIaBChlnNGZ6ywCnIQl+wnlPphgavDUa7Vml9SOcw6cH+GACAxue SdK/h39utxJglFgbkmp6UmEv4xXBLLQKtC7ImuMTeS7ujYUucN2gTK+q5Lz5LwvkQfZj 3MmJIcS7zCJo6ALE0udw2+fB1fOtnJqYDFiBmeKkjo2AP4a9HEaGZhjjk5ujR0uLHYX2 MH4mpL8AmN0XJ0hHnQPa/pvRMy6PWQ4h9kW+/U4buPw4/dTedDIlw1HmTek8OUBtwCKZ Ne5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=oawvsSmOiJWb5tMjiSLRsp58BTv+snGWdLXEJpaaGbw=; b=dX2/ggJk0ZVY+2Us2k0YUXAEKuEu3QfghE0sQBa2vUpFz/jFZzRj8k3rsaYv6idZmN oT5lvBWzjUtMLPETaB3bHybMyIxeyAHx96MwuZnI6HHHpNf+RqCgoCAnQNNNo1UyBujN h8CXlZ+e6aisp5GFQwwN4IiPmaOA2MCu8dNM9F4Dyy2ifK/LwO9Wg9iI7he+dOW+xTHd gbQLZSxuwb8AAmZ/7WcHcoRz0H8AQz8Gluc9UwDcVx26UImgDFi/TZ/u9YDY9Zcqpi2j itnS0UGFs+TbkvHRZv+FxUCR5E3fKhvy92KNPcNJ7gInufn0LS2I9AEs1qoF6ybZRHrR Uf7g== X-Gm-Message-State: ALQs6tDzL8gNNm3WAjfhw1E0bjMpinM8Pp2GB9+PuJGOxTAictFzscWz ZpDa+b7KRRdALxa7fxC6a3wa6+CuL3z/y/UpQmJnjQ== X-Google-Smtp-Source: AB8JxZpuFonqREYBRVMEO7Kb9pYLV9pjvkkQYy41EEdeSAQbcXgjSGJ61wUvYf1QKzM09XzTvSxrjewMXs3cYPG343g= X-Received: by 2002:a6b:d404:: with SMTP id l4-v6mr19844971iog.37.1524499623955; Mon, 23 Apr 2018 09:07:03 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:a604:0:0:0:0:0 with HTTP; Mon, 23 Apr 2018 09:07:03 -0700 (PDT) X-Originating-IP: [50.227.106.226] In-Reply-To: References: <201804211705.w3LH50Dk056339@repo.freebsd.org> <20180422171106.GB84833@raichu> From: Warner Losh Date: Mon, 23 Apr 2018 10:07:03 -0600 X-Google-Sender-Auth: pjIesHLsvT6PsJ78FZiHWack1HY Message-ID: Subject: Re: svn commit: r332860 - head/sys/kern To: "Jonathan T. Looney" Cc: Mark Johnston , "Conrad E. Meyer" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 16:07:06 -0000 On Mon, Apr 23, 2018 at 9:12 AM, Jonathan T. Looney wrote: > > If we leave the default alone, I agree we should print the assertion > message (albeit with some rate limit). > We should print the first N asserts we hit during a kernel panic core dump, then stop. I'd suggest N should be 10 or 20. For me, the only asserts that have value during a panic are the ones that prevent bad things from happening. The only bad thing that really can happen is either wedging the machine, so we don't finish the dump (watchdogs solve that) or writing to a naughty place (defined as not within the bounds of a swap partition). I'm having a hard time seeing in what actual value assertions that aren't related to either of these areas buy us. Warner