Date: Sat, 3 Jun 2023 22:29:12 +0300 From: Dmitry Chagin <dchagin@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 1b0d96f3c43a - main - xregs_sig: Finish renaming simd to xregs before adding avx Message-ID: <ZHuUiJVoTqWwZ1Yo@heemeyer.club> In-Reply-To: <3F83B6B8-7A16-488B-9594-50A7426931F5@freebsd.org> References: <202306031713.353HDY7D036200@gitrepo.freebsd.org> <FF273FCA-C081-4AF6-9D75-1AD86EAE68AE@freebsd.org> <ZHuLcBsQmp-Yw649@heemeyer.club> <3F83B6B8-7A16-488B-9594-50A7426931F5@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 03, 2023 at 07:57:03PM +0100, Jessica Clarke wrote: > On 3 Jun 2023, at 19:50, Dmitry Chagin <dchagin@freebsd.org> wrote: > > > > On Sat, Jun 03, 2023 at 07:05:48PM +0100, Jessica Clarke wrote: > >> On 3 Jun 2023, at 18:13, Dmitry Chagin <dchagin@FreeBSD.org> wrote: > >>> > >>> The branch main has been updated by dchagin: > >>> > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=1b0d96f3c43a5f997dca120a83a4b06995df345b > >>> > >>> commit 1b0d96f3c43a5f997dca120a83a4b06995df345b > >>> Author: Dmitry Chagin <dchagin@FreeBSD.org> > >>> AuthorDate: 2023-06-03 17:11:44 +0000 > >>> Commit: Dmitry Chagin <dchagin@FreeBSD.org> > >>> CommitDate: 2023-06-03 17:11:44 +0000 > >>> > >>> xregs_sig: Finish renaming simd to xregs before adding avx > >> > >> Isn’t this the wrong direction? “xregs” sounds specific to x86’s xmm > >> registers; arm64’s q NEON registers are definitely not “xregs”, those > >> are the standard GPRs. > >> > > NEON registers is not GPRs, here xregs is all non GPRs, ie, sse, avx, > > neon, etc. > > But the AArch64 registers are called x0 through x30. They are x > registers. So calling the SIMD registers X registers is both incorrect > and highly confusing. It is not general, it is specific to x86’s notion > of SIMD. Naming is hard (c) especially for non-native :), I just need an avx registers test to fix golang issues in the Linuxulator. Feel free to join D40410, D40384, propose you naming variant, may be x->ext or ngprs > > Jess > > >> Jess > >> > >>> Reviewed by: kib, jhb > >>> Differential Revision: https://reviews.freebsd.org/D40382 > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZHuUiJVoTqWwZ1Yo>