From owner-freebsd-ports@FreeBSD.ORG Sun Dec 16 11:26:06 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E0FA2DC5; Sun, 16 Dec 2012 11:26:06 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward12.mail.yandex.net (forward12.mail.yandex.net [IPv6:2a02:6b8:0:801::2]) by mx1.freebsd.org (Postfix) with ESMTP id 4D9358FC0C; Sun, 16 Dec 2012 11:26:06 +0000 (UTC) Received: from smtp14.mail.yandex.net (smtp14.mail.yandex.net [95.108.131.192]) by forward12.mail.yandex.net (Yandex) with ESMTP id F3374C21EAC; Sun, 16 Dec 2012 15:26:03 +0400 (MSK) Received: from smtp14.mail.yandex.net (localhost [127.0.0.1]) by smtp14.mail.yandex.net (Yandex) with ESMTP id A382C1B60644; Sun, 16 Dec 2012 15:26:01 +0400 (MSK) Received: from unknown (unknown [77.66.155.61]) by smtp14.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Q1cec6Jg-Q1cmg4GK; Sun, 16 Dec 2012 15:26:01 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1355657161; bh=LwtRDZhRwlKilkO+wNGwpS7qMhI9EluPSkZcNK+8sGE=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=QDg7aJcMmRtylfepuudGIj6l/dbnGG5aoQ/e7NXtPlJfxilNo9OXzqd376fHo/p+J Y5oYLdVxkTtqbiwzEnVJeisC5PyxTryblR2h0NlqCkz4ekWQNA4g9Xgdc9gLk0U+0J v0m972NyNrsrDLNY0t+IR1wyanS/AFukHJtgK1r0= Message-ID: <50CDAF9F.5070601@yandex.ru> Date: Sun, 16 Dec 2012 15:25:19 +0400 From: Ruslan Makhmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: "Jason E. Hale" Subject: Re: [@ ports committers] ports/173531 References: <50CD99F2.4010205@gmx.eu> <50CDA9A7.7010401@yandex.ru> <50CDAB84.5050701@yandex.ru> <3096099.yLIANgpWSo@mocha.verizon.net> In-Reply-To: <3096099.yLIANgpWSo@mocha.verizon.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: marco.broeder@gmx.eu, freebsd-ports@freebsd.org, bug-followup@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2012 11:26:07 -0000 Jason E. Hale wrote on 16.12.2012 15:13: > On Sunday, December 16, 2012 15:07:48 Ruslan Makhmatkhanov wrote: >> Ruslan Makhmatkhanov wrote on 16.12.2012 14:59: >>> Hi Marco, >>> >>> Marco Bröder wrote on 16.12.2012 13:52: >>>> Hi, >>>> >>>> could a ports committer take ports/173531 pr, please? It is unassigned >>>> for >>>> over a month, now. >>>> >>>> Thank you very much! >>> >>> Please review patch attached. I changed some things in your patch: >>> - using OPTIONSFILE instead of UNIQUENAME (it's common practice to fix >>> >>> things like that) >>> >>> - limit to python 2.x (dulwich is not python 3.x-aware yet) >>> - tab -> space change in pkg-descr:WWW (style bug) >>> - remove DOCS_DESC (we have generic description in bsd.options.desc.mk) >>> - use PYTHON_CMD instead of ``/usr/bin/env python'' (to make sure it >>> >>> will be runned with the same python branch, that it was built with) >>> >>> Please let me know if you agree with the changes, and I commit the >>> update shortly. >>> >>> PS. Surely, it builds fine with this patch. >> >> Oops, I see that this pr was taken by jhale already :) > > Ruslan, > > If you want to take this that is fine with me...I haven't started working on > it yet and it seems you have looked into it already. > >> One more thing - PORTDOCS should be defined uncoditionally, but >> installed conditionally: >> >> +.if ${PORT_OPTIONS:MDOCS} >> +PORTDOCS= AUTHORS COPYING HACKING NEWS README introduction.txt \ >> + object-store.txt protocol.txt remote.txt repo.txt >> .endif >> > COPYING should be removed here too. LICENSE is already defined. > >> This condition is not necessary. Ok, both done (take-pr and COPYING). Thanks. Awaiting of maintainer's response. -- Regards, Ruslan Tinderboxing kills... the drives.