From owner-svn-src-all@FreeBSD.ORG Wed Jan 21 03:59:11 2015 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 31B7617E; Wed, 21 Jan 2015 03:59:11 +0000 (UTC) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 18A9DCF9; Wed, 21 Jan 2015 03:59:10 +0000 (UTC) Received: from comporellon.tachypleus.net (polaris.tachypleus.net [75.101.50.44]) (authenticated bits=0) by d.mail.sonic.net (8.14.9/8.14.9) with ESMTP id t0L3x8UX021332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 20 Jan 2015 19:59:08 -0800 Message-ID: <54BF240C.2090107@freebsd.org> Date: Tue, 20 Jan 2015 19:59:08 -0800 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Konstantin Belousov Subject: Re: svn commit: r277421 - head/sys/powerpc/powerpc References: <201501201621.t0KGLx26096724@svn.freebsd.org> <20150120191438.GL42409@kib.kiev.ua> In-Reply-To: <20150120191438.GL42409@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Sonic-CAuth: UmFuZG9tSVacb8wDZv0nddrVr10W1s6eMKnHJOWqR0nYT6S+PdCVoOGT3fWV1nyrKbPMDkNTki2bK4U+k+F9tS5JWRFpKlWb91Sdq6JSHcs= X-Sonic-ID: C;st+L2SGh5BGO8JCx7jkJAQ== M;vMjU2SGh5BGO8JCx7jkJAQ== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 03:59:11 -0000 On 01/20/15 11:14, Konstantin Belousov wrote: > On Tue, Jan 20, 2015 at 04:21:59PM +0000, Nathan Whitehorn wrote: >> Author: nwhitehorn >> Date: Tue Jan 20 16:21:59 2015 >> New Revision: 277421 >> URL: https://svnweb.freebsd.org/changeset/base/277421 >> >> Log: >> There does not seem to be any reason to acquire GIANT here. Follow amd64 >> in removing it. >> >> MFC after: 1 month >> >> Modified: >> head/sys/powerpc/powerpc/mem.c >> >> Modified: head/sys/powerpc/powerpc/mem.c >> ============================================================================== >> --- head/sys/powerpc/powerpc/mem.c Tue Jan 20 15:45:09 2015 (r277420) >> +++ head/sys/powerpc/powerpc/mem.c Tue Jan 20 16:21:59 2015 (r277421) >> @@ -100,8 +100,6 @@ memrw(struct cdev *dev, struct uio *uio, >> cnt = 0; >> error = 0; >> >> - GIANT_REQUIRED; >> - > This is not an acquisition, to be pedantic. Really, it is cdevsw which > has D_NEEDGIANT flag which acquires Giant. After architectures get > rid of GIANT_REQUIRED, flag can be removed. > Just so I understand, you are not objecting to this commit, right? Just pointing out that (a) my commit message was wrong and that (b) once all architectures make this change (presumably more involved) we can get rid of the D_NEEDGIANT in /sys/dev/mem/memdev.c? -Nathan