From owner-cvs-src@FreeBSD.ORG Sun Jul 3 01:10:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 077C816AA11; Sun, 3 Jul 2005 00:58:36 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id E390844693; Sun, 3 Jul 2005 00:42:47 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 0BCF46DCE1; Sat, 2 Jul 2005 17:38:11 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 3635C5C9A5 for ; Tue, 25 Jan 2005 02:37:42 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 04F5156111 for ; Tue, 25 Jan 2005 10:37:42 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id F244D16A4EE; Tue, 25 Jan 2005 10:37:36 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 0B73816A4D0; Tue, 25 Jan 2005 10:37:35 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB2D116A4CE; Tue, 25 Jan 2005 10:37:33 +0000 (GMT) Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3606E43D4C; Tue, 25 Jan 2005 10:37:33 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j0PAbW5R080963; Tue, 25 Jan 2005 11:37:32 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Andrey Chernov From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 25 Jan 2005 13:32:50 +0300." <20050125103250.GA29461@nagual.pp.ru> Message-ID: <80962.1106649452@critter.freebsd.dk> Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:10:53 -0000 X-Original-Date: Tue, 25 Jan 2005 11:37:32 +0100 X-List-Received-Date: Sun, 03 Jul 2005 01:10:53 -0000 In message <20050125103250.GA29461@nagual.pp.ru>, Andrey Chernov writes: >On Tue, Jan 25, 2005 at 11:26:32AM +0100, Poul-Henning Kamp wrote: >> Show me code which breaks please. > >It is not an argument. Your commit violates both POSIX and SUSv3, namely >this thing: > >"This volume of IEEE Std 1003.1-2001 requires that no action be taken for >read() or write() when nbyte is zero. This is not intended to take >precedence over detection of errors (such as invalid buffer pointers or >file descriptors). This is consistent with the rest of this volume of IEEE >Std 1003.1-2001, but the phrasing here could be misread to require >detection of the zero case before any other errors." Notice the "require" it doesn't ban the practice. >If you read my previous message to the end, I already mention the case >which is obviously broken: FIFOs blocking and EAGAIN returning - it must >happens for zero byte reads too. Go look at fifofs: we never did that (please see also rev. 1.104 to avoid a tiresome round of "you broke this" "no I didn't"). -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.