Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Sep 2000 08:00:02 -0700 (PDT)
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        freebsd-ports@FreeBSD.org
Subject:   Re: ports/20995: freeciv-civ gtk make problem.
Message-ID:  <200009041500.IAA09468@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/20995; it has been noted by GNATS.

From: Maxim Sobolev <sobomax@FreeBSD.org>
To: fujie@tk.elec.waseda.ac.jp, sheldonh@FreeBSD.org,
	freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/20995: freeciv-civ gtk make problem.
Date: Mon, 04 Sep 2000 17:55:10 +0300

 This is a multi-part message in MIME format.
 --------------6C9373E0BCE9158AF1AF4AB9
 Content-Type: text/plain; charset=x-user-defined
 Content-Transfer-Encoding: 7bit
 
 Shinya FUJIE wrote:
 
 >   Sorry, but I sent wrong patch.
 >
 >   According to CVS Repository,
 > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/games/freeciv/Makefile
 >
 >   Makefile of freeciv port sets GLIB_CONFIG
 > GLIB_CONFIG?=   ${LOCALBASE}/bin/gtk12-config
 > but I think it should be set like
 > GLIB_CONFIG?=   ${X11BASE}/bin/gtk12-config
 >
 > so patch as follow is wrong ;(
 > >      ! GLIB_CONFIG?= ${X11BASE}/bin/gtk12-config
 > >        CONFIGURE_ENV=        GTK_CONFIG="${GLIB_CONFIG}"
 > >        .else
 > >        CONFIGURE_ARGS=       --disable-gtktest
 > >      --- 25,31 ----
 > >        USE_BZIP2=    yes
 > >        GNU_CONFIGURE=        yes
 > >        .if defined(WITH_GTK)
 > >      ! GLIB_CONFIG?= ${LOCALBASE}/bin/gtk12-config
 
 I see. BTW, the name of variable is just plain wrong, which can cause
 confusion. How about the following patch?
 
 -Maxim
 (CC'ing to maintainer)
 
 
 
 --------------6C9373E0BCE9158AF1AF4AB9
 Content-Type: text/plain; charset=x-user-defined;
  name="freeciv.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="freeciv.diff"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/games/freeciv/Makefile,v
 retrieving revision 1.35
 diff -d -u -r1.35 Makefile
 --- Makefile	2000/08/03 09:23:29	1.35
 +++ Makefile	2000/09/04 14:51:27
 @@ -25,8 +25,8 @@
  USE_BZIP2=	yes
  GNU_CONFIGURE=	yes
  .if defined(WITH_GTK)
 -GLIB_CONFIG?=	${LOCALBASE}/bin/gtk12-config
 -CONFIGURE_ENV=	GTK_CONFIG="${GLIB_CONFIG}"
 +GTK_CONFIG?=	${X11BASE}/bin/gtk12-config
 +CONFIGURE_ENV=	GTK_CONFIG="${GTK_CONFIG}"
  .else
  CONFIGURE_ARGS=	--disable-gtktest
  .endif
 
 --------------6C9373E0BCE9158AF1AF4AB9--
 
 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009041500.IAA09468>