From owner-freebsd-current@FreeBSD.ORG  Tue Nov 28 19:45:42 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8A36F16A417;
	Tue, 28 Nov 2006 19:45:42 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B890D43DAF;
	Tue, 28 Nov 2006 19:41:49 +0000 (GMT) (envelope-from sam@errno.com)
Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id kASJfjxR012296
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 28 Nov 2006 11:41:47 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <456C90F9.5080209@errno.com>
Date: Tue, 28 Nov 2006 11:41:45 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 1.5.0.7 (X11/20060920)
MIME-Version: 1.0
To: Robert Watson <rwatson@freebsd.org>
References: <20061129.015826.74756053.haro@h4.dion.ne.jp>
	<20061128180811.P95096@fledge.watson.org>
In-Reply-To: <20061128180811.P95096@fledge.watson.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Munehiro Matsuda <haro@h4.dion.ne.jp>, freebsd-current@freebsd.org
Subject: Re: LOR with netisr changes
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2006 19:45:42 -0000

Robert Watson wrote:
> 
> On Wed, 29 Nov 2006, Munehiro Matsuda wrote:
> 
>> JFYI, I got following LOR started after the netisr changes:
> 
> In general, device driver locks should not be held over entry to the
> network stack.  However, things get a bit tricky in the 802.11 code due
> to lock sharing, I believe, so it could be a bit more tricky to fix that.

It's just a bug in the driver.  Driver locks should be dropped when
packets get passed up the stack.  This issue was pointed out before iwi
ever was committed but since nothing immediately comes back via the
bridge (or similar) it's been ignored.

	Sam