From owner-freebsd-ports@FreeBSD.ORG Sun Jan 23 10:43:01 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6EDCA106566C for ; Sun, 23 Jan 2011 10:43:01 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id ECB4A8FC13 for ; Sun, 23 Jan 2011 10:43:00 +0000 (UTC) Received: by bwz12 with SMTP id 12so2907972bwz.13 for ; Sun, 23 Jan 2011 02:42:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=nU/UIXB+P6tezTVBbWqJHvxcrn+tg8eRwsoM9Q3yS+Y=; b=an/hJbgd6vvUY8RhTVYPvIt1CEMbC3BFadMx/uAcgDFJNaKtitpz+ZV/sFTUiQsZpj mISFreQ2qFXq9Xx0jT/ULcLZD31XENgXjTmpnCt1o7uWtjBBRiAprNgpbudeoI4q8CFO n4xT5KUo0JQHFYvuwjaJ3qr/3eO8QOVHAPxy4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; b=F0OLj6NEo7C4CrEJurZMO9UkbiRXW7CcziM7/59r1ea/Ht3cxqxco/jO162QdPQxOo Q0VuAB5N+FKXMpACU/uCm9aDGRnW2Cke03kxBWOjKAwh1G/rBefX2YCIrj5mvglrXCBZ 74z0EqcocnvCANWStip2IZWNaf6MuemKXqxno= Received: by 10.204.122.17 with SMTP id j17mr2478341bkr.4.1295779378588; Sun, 23 Jan 2011 02:42:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.52.19 with HTTP; Sun, 23 Jan 2011 02:42:28 -0800 (PST) In-Reply-To: References: <4D39FEBA.3000806@janh.de> <4D3AF40E.7090301@janh.de> From: Chris Rees Date: Sun, 23 Jan 2011 10:42:28 +0000 Message-ID: To: Jan Henrik Sylvester Content-Type: text/plain; charset=ISO-8859-1 Cc: ports-list freebsd Subject: Re: Xournal: Please, help me with my first port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: utisoft@gmail.com List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jan 2011 10:43:01 -0000 On 22 January 2011 16:28, Chris Rees wrote: > On 22 January 2011 15:13, Jan Henrik Sylvester wrote: >>>> The DATADIR whines are addressed in this patch, have a look: >>>> >>>> http://www.bayofrum.net/~chris/patches/xournal-pkg-plist.diff >> >> Thanks, but since the port does not honor DATADIR, it should not be there -- >> or the DATADIR case must be fixed first. > > Addressed below. > >> >>>> That's all I had time to look at at the moment, perhaps others can help! >>>> >>> >>> Alright, came back and now the patch has the desktop-install target >>> defined instead of using the post-install. This is reflected in the >>> patch linked above ^^^ >> >> Thanks, I was looking for something like that, but it should be >> "INSTALL_TARGET= install desktop-install", because desktop-install does not >> include install. > > Certainly. Looks as though we should define the do-install: target > rather than rely > on the provided ones; this means that we can make the port DATADIR safe. I'll > look shortly. > >> >>> I've stuck it in my Tinderbox for testing, follow it here: >>> http://tinderbox.bayofrum.net/index.php?action=describe_port&id=196 >> >> Thanks! >> >> I do not know Tinderbox enough to understand, why your mkfontscale build >> tried to install an outdated version of freetype2. >> > Take a look at the new patch so far; I'm still working on Busybox at the moment, so I'm afraid I can't step too much more through it, but it should give you a little more to work on. I've tidied the REINPLACE lines for you too. http://www.bayofrum.net/~chris/patches/xournal.diff DATADIR-safe appears unnecessary according to the conversation http://www.mailinglistarchive.com/freebsd-ports@freebsd.org/msg08234.html , so I think that this port should be fine as is right now. Try submitting it, it should be fine. Cheers! Chris