From owner-freebsd-net@FreeBSD.ORG  Wed Sep 26 20:21:11 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EDF131065674;
	Wed, 26 Sep 2012 20:21:10 +0000 (UTC)
	(envelope-from jfvogel@gmail.com)
Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com
	[209.85.220.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 7FF138FC0C;
	Wed, 26 Sep 2012 20:21:10 +0000 (UTC)
Received: by vcbfw7 with SMTP id fw7so1562724vcb.13
	for <multiple recipients>; Wed, 26 Sep 2012 13:21:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=Udu8wDM/HUQpbYfgqkwpmlm8DcXWG7Q3ynb21SsjK3A=;
	b=z8hmfxIqNwXOVk3+4a7SOHzH04pRBk9mbcg+7WKWaHz2CYThUzldtcobSUH6Gs37wB
	Dvu0rvTBbRQJrx+B4OgRkQniq9Okp61fPHwkRATZ+LaBqchz2iWmMA4wnwbXnclaiO48
	cI02NxS/98vLCMmRRr1vn2nbKChH/7LkupOQDMf7S+RwTtAVoIAym8X4ZBHReX8yF6KJ
	zCv1d7pzfDSWvoJKzx5sf53BFA2XDheJkTlqymkSgSW9RYc4uoyuW5MrdBFB9gA9uYuR
	nPy0QkfKYlLmN1+2m7MNWWDF9UPYgqoKVihQXfvO3O4HBNpifXlxrETOCrWr13TnE2H5
	ZzTA==
MIME-Version: 1.0
Received: by 10.52.27.133 with SMTP id t5mr750614vdg.111.1348690869699; Wed,
	26 Sep 2012 13:21:09 -0700 (PDT)
Received: by 10.58.68.8 with HTTP; Wed, 26 Sep 2012 13:21:09 -0700 (PDT)
In-Reply-To: <CALCNsJRR_=HqRWUduDk2GPKcnSgaHky4ybTjUa_BXfwcA3W88g@mail.gmail.com>
References: <CALCNsJSSQSWV7vNVR-Sn8CPDKbUBBLpSH0b-HYMJo3SXvkOY=w@mail.gmail.com>
	<201208161736.47250.jhb@freebsd.org>
	<CAFOYbc=bXv_V4egO94ftkTFoLQ2uM50Sw3X5kgYoyKQcd0s31A@mail.gmail.com>
	<201208170941.54482.jhb@freebsd.org>
	<CALCNsJQ740ceDzpd5n7QAALn-uJ-GdWxPTkQJuMJUMTUGJjOUg@mail.gmail.com>
	<CAFOYbcmuxBmOfC6P0UBG5RR7xJy_i5mTr2NGMRcTJEJrQmjQ_Q@mail.gmail.com>
	<CALCNsJQkLdEMkCUfp00woGbf-uUCOQVt5mJuZfrRTw9PRGYM9w@mail.gmail.com>
	<CALCNsJRR_=HqRWUduDk2GPKcnSgaHky4ybTjUa_BXfwcA3W88g@mail.gmail.com>
Date: Wed, 26 Sep 2012 13:21:09 -0700
Message-ID: <CAFOYbck=64JLytSLqeUaOhn70pBaNDPHBVY2T3b90RXMyK0+RA@mail.gmail.com>
From: Jack Vogel <jfvogel@gmail.com>
To: Vijay Singh <vijju.singh@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: freebsd-net@freebsd.org, John Baldwin <jhb@freebsd.org>
Subject: Re: ixgbe rx & tx locks
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2012 20:21:11 -0000

On Wed, Sep 26, 2012 at 1:14 PM, Vijay Singh <vijju.singh@gmail.com> wrote:

> > Jack, I am wondering if this could be avoided if we can avoid to
> > enqueue the task OR re-enable interrupts if the other one is already
> > scheduled. Is this possible?
>
> It seems to me that ixgbe_handle_que() should only be doing
> ixgbe_rxeof(). When ever mq_start() is unable to send, it enqueues the
> new txq_task. Also, this is checked periodically from the timer
> function as well. I will try an experiment to evaluate only more_rx in
> ixgbe_msix_que() and change ixgbe_handle_que() to do rx processing
> only. I will report back findings.
>
> Meanwhile it its immediately obvious to anyone what this will break,
> please let me know.
>
> -vijay
>

OK, will be interested in the results.

Jack