From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Nov 19 07:02:57 2010 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4388106564A; Fri, 19 Nov 2010 07:02:57 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id CBE7D8FC08; Fri, 19 Nov 2010 07:02:56 +0000 (UTC) Received: by fxm19 with SMTP id 19so2511351fxm.13 for ; Thu, 18 Nov 2010 23:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=Ykh/jENBa14aK1coLURIDlDxxuf8SQkLQgA3t0+/dic=; b=vfsih/DzC2FYTBCNMUsksGWNJA3JEuyqIsu7/s/WMhsHumoeIwQChuNecrDeXCAqbL 2JtlRKofQdx+obuZeorr/0duwNw399bcF1XW4xE0scnb5sPvdVaHQOm4jUEEbq4DIbSK Jabi9q1FECofdg5aBAo0DENGPyXK8R50RjPwY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=pHyhfDBu5K4w2Q7Lql9+1iH7qMoaKvhWSz0icTqnbvV7fBwoRT1eQ8RSMTeNPjU6RM 9IGUVjaRFCDTHQhoLeVnf1OKImKNZeCyMGym9+XB41UZaFlxw6on45d3viHmmMGc2Gwr mP0mw18Pq7rEz2hpHdNxim5m513HibKeV6LOI= Received: by 10.223.83.133 with SMTP id f5mr456679fal.29.1290150175737; Thu, 18 Nov 2010 23:02:55 -0800 (PST) Received: from localhost ([87.236.194.97]) by mx.google.com with ESMTPS id j14sm418490faa.47.2010.11.18.23.02.52 (version=SSLv3 cipher=RC4-MD5); Thu, 18 Nov 2010 23:02:53 -0800 (PST) From: Anonymous To: bug-followup@freebsd.org References: <86632cpaiv.fsf@gmail.com> Date: Fri, 19 Nov 2010 10:02:48 +0300 In-Reply-To: <86632cpaiv.fsf@gmail.com> (Anonymous's message of "Tue, 25 May 2010 13:59:20 +0400") Message-ID: <86zkt5g5if.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/146961: [patch] devel/git: strip(1) binaries by default for non-debug builds X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2010 07:02:57 -0000 Hmm, it's better to use same check as in ports/150689. WITH_DEBUG is for things like -DDEBUG, i.e. compile-time optimization that hurts performance while debug symbols usually do not. --- a.diff begins here --- Index: devel/git/Makefile =================================================================== RCS file: /a/.cvsup/ports/devel/git/Makefile,v retrieving revision 1.94 diff -u -p -r1.94 Makefile --- devel/git/Makefile 23 Oct 2010 15:07:55 -0000 1.94 +++ devel/git/Makefile 26 Oct 2010 19:32:27 -0000 @@ -195,7 +195,7 @@ OPTIONS= GUI "Enable building of GUI too .include -.ifndef (WITH_DEBUG) +.ifdef (STRIP) && ${STRIP} != "" ALL_TARGET= all strip .endif --- a.diff ends here ---