Date: Fri, 19 Nov 2010 10:02:48 +0300 From: Anonymous <swell.k@gmail.com> To: bug-followup@freebsd.org Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/146961: [patch] devel/git: strip(1) binaries by default for non-debug builds Message-ID: <86zkt5g5if.fsf@gmail.com> In-Reply-To: <86632cpaiv.fsf@gmail.com> (Anonymous's message of "Tue, 25 May 2010 13:59:20 %2B0400") References: <86632cpaiv.fsf@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hmm, it's better to use same check as in ports/150689.
WITH_DEBUG is for things like -DDEBUG, i.e. compile-time optimization
that hurts performance while debug symbols usually do not.
--- a.diff begins here ---
Index: devel/git/Makefile
===================================================================
RCS file: /a/.cvsup/ports/devel/git/Makefile,v
retrieving revision 1.94
diff -u -p -r1.94 Makefile
--- devel/git/Makefile 23 Oct 2010 15:07:55 -0000 1.94
+++ devel/git/Makefile 26 Oct 2010 19:32:27 -0000
@@ -195,7 +195,7 @@ OPTIONS= GUI "Enable building of GUI too
.include <bsd.port.options.mk>
-.ifndef (WITH_DEBUG)
+.ifdef (STRIP) && ${STRIP} != ""
ALL_TARGET= all strip
.endif
--- a.diff ends here ---
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86zkt5g5if.fsf>