From owner-svn-ports-all@freebsd.org Fri Oct 7 06:38:07 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4251BBEC7A7; Fri, 7 Oct 2016 06:38:07 +0000 (UTC) (envelope-from brnrd@FreeBSD.org) Received: from smtp02.qsp.nl (smtp02.qsp.nl [193.254.214.163]) by mx1.freebsd.org (Postfix) with ESMTP id 01862311; Fri, 7 Oct 2016 06:38:06 +0000 (UTC) (envelope-from brnrd@FreeBSD.org) Received: from smtp02.qsp.nl (localhost [127.0.0.1]) by smtp02.qsp.nl (Postfix) with ESMTP id 72F48FD0BC; Fri, 7 Oct 2016 08:38:05 +0200 (CEST) Received: from mail.brnrd.eu (unknown [193.164.217.85]) by smtp02.qsp.nl (Postfix) with ESMTP; Fri, 7 Oct 2016 08:38:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=brnrd.eu; h=date:from:to:subject:message-id; s=default; bh=7dLKYsnsSPHlhzwESVppgZ3MLL3PVYCL0WPVGZXFOYU=; b=AcW9zOu7G8VBWnyb/r12fZNpeTCSOKTLHY/WKcvp1C8gtct4ndP8xtCXRBK/0KFfeA5OmFv2MLRERD3QbE9KA12eKfdqlVZDf49VtyHIZvv2GbUi6pPJv1S7PRvEvV4iinW9Us/koZx9va0rsIdI0S3T29eqR6d7DIFICU0cuRmoGaylJ5e3a7np5EAXU/mIRdBbhlnM152fOg+MJnfQaysWrBpA8dnG5vOlMeH9zKfCer5eWLAD6PRIXFbweA+QjF9MCENTVT0ihfsR8wsjn7nu19zjoERCyOL6HGjRlBWf+HymIMcZiEiD1Pbcw1ajCJOoB0WNTBqf56tvBlAGXg== Received: by bachfreund.nl (OpenSMTPD) with ESMTPSA id 93afb117 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Fri, 7 Oct 2016 08:38:04 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 07 Oct 2016 08:38:04 +0200 From: Bernard Spil To: Joseph Mingrone Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r423434 - head/security/openssl In-Reply-To: <861szsvni2.fsf@phe.ftfl.ca> References: <201610061938.u96JcmrW038201@repo.freebsd.org> <861szsvni2.fsf@phe.ftfl.ca> Message-ID: X-Sender: brnrd@FreeBSD.org User-Agent: Roundcube Webmail/1.2.2 X-Virus-Scanned: clamav at smtp02 X-Spam-Status: No, score=1.6 required=5.0 tests=HK_RANDOM_ENVFROM, HK_RANDOM_FROM,UNPARSEABLE_RELAY autolearn=disabled version=3.4.1 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on svfilter01.qsp.nl X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 06:38:07 -0000 On 2016-10-07 5:36, Joseph Mingrone wrote: > Mathieu Arnold writes: > >> Le 06/10/2016 à 21:38, Bernard Spil a écrit : >>> Author: brnrd >>> Date: Thu Oct 6 19:38:48 2016 >>> New Revision: 423434 >>> URL: https://svnweb.freebsd.org/changeset/ports/423434 > >>> Log: >>> security/openssl: Fix ldconfig issue > >>> - OPT_USE= feature does not behave as expected > >> I strongly disagree with that comment, the opt_USE works exactly as >> expected, and as documented. > > If I am understanding the documentation correctly > > OPT_USE= ldconfig=${PREFIX}/lib/blah/lib > > should add ${PREFIX}/lib/blah/lib to > ${LOCALBASE}/libdata/ldconfig/blah. > > I just tested and it is not creating > ${LOCALBASE}/libdata/ldconfig/blah when OPT is on. > > The code below does. > > .if ${PORT_OPTIONS:MOPT} > USE_LDCONFIG= ${PREFIX}/lib/blah/lib > .endif Hi Joseph, That's another issue which is specific to using ${PREFIX} at this stage. When I set SHARED_USE= ldconfig=${PREFIX}/lib/blah $ make -VUSE_LDCONFIG /lib/blah as ${PREFIX} isn't set during options processing I was just looking for the default behavior here. Setting SHARED_USE= ldconfig results in $ make -VUSE_LDCONFIG ldconfig for lack of an `=' character in the SHARED_USE value. I have created D8166 that simply sets USE_FEATURE= yes when no `=' is present in OPT_USE= feature. Cheers, Bernard.