From owner-svn-src-all@FreeBSD.ORG Mon Oct 17 00:16:27 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29C47106566C; Mon, 17 Oct 2011 00:16:27 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) by mx1.freebsd.org (Postfix) with ESMTP id AD3EA8FC12; Mon, 17 Oct 2011 00:16:26 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 9D55D25D37C7; Mon, 17 Oct 2011 00:16:25 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id BEE51BD3C4D; Mon, 17 Oct 2011 00:16:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id U2KUOB+W7yuZ; Mon, 17 Oct 2011 00:16:23 +0000 (UTC) Received: from orange-en1.sbone.de (orange-en1.sbone.de [IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 39076BD3C2E; Mon, 17 Oct 2011 00:16:23 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: "Bjoern A. Zeeb" In-Reply-To: <201110170005.p9H05VrP086262@svn.freebsd.org> Date: Mon, 17 Oct 2011 00:16:22 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201110170005.p9H05VrP086262@svn.freebsd.org> To: src-committers@freebsd.org X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r226454 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2011 00:16:27 -0000 On 17. Oct 2011, at 00:05 , Bjoern A. Zeeb wrote: > Author: bz > Date: Mon Oct 17 00:05:31 2011 > New Revision: 226454 > URL: http://svn.freebsd.org/changeset/base/226454 >=20 > Log: > Add syntactic sugar missed in r226437 and then not added either when = moving > things around in r226448 but desperately needed to always make things > compile successfully. >=20 GENRIC and LINT did not fail failed on it as it expanded to: int tcp_recvspace =3D 1024*64 followed by: #define SYSCTL_VNET_INT(parent, nbr, name, access, ptr, val, descr) = \ SYSCTL_INT(parent, nbr, name, access, ptr, val, descr) =20 =3D> #define SYSCTL_INT(parent, nbr, name, access, ptr, val, descr) = \=20 SYSCTL_ASSERT_TYPE(INT, ptr, parent, name); = \ SYSCTL_OID(parent, nbr, name, = \ CTLTYPE_INT | CTLFLAG_MPSAFE | (access), = \ ptr, val, sysctl_handle_int, "I", descr) and the SYSCTL_ASSERT_TYPE() expanding to nothing in #define SYSCTL_ASSERT_TYPE(type, ptr, parent, name) leaving just the ';' around; so it ended up as: int tcp_recvspace =3D 1024*64 ; and an expanded SYSCTL_OID(...); > MFC after: 1 week >=20 > Modified: > head/sys/netinet/tcp_input.c >=20 > Modified: head/sys/netinet/tcp_input.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/netinet/tcp_input.c Sun Oct 16 22:24:04 2011 = (r226453) > +++ head/sys/netinet/tcp_input.c Mon Oct 17 00:05:31 2011 = (r226454) > @@ -183,7 +183,7 @@ SYSCTL_VNET_INT(_net_inet_tcp, OID_AUTO, > &VNET_NAME(tcp_insecure_rst), 0, > "Follow the old (insecure) criteria for accepting RST packets"); >=20 > -VNET_DEFINE(int, tcp_recvspace) =3D 1024*64 > +VNET_DEFINE(int, tcp_recvspace) =3D 1024*64; > #define V_tcp_recvspace VNET(tcp_recvspace) > SYSCTL_VNET_INT(_net_inet_tcp, TCPCTL_RECVSPACE, tcp_recvspace, = CTLFLAG_RW, > &VNET_NAME(tcp_recvspace), 0, "Initial receive socket buffer = size"); --=20 Bjoern A. Zeeb You have to have visions! Stop bit received. Insert coin for new address family.